Bug 162180 - REGRESSION (r205275): LOG_WITH_STREAM() macros are all compiled in release builds now
Summary: REGRESSION (r205275): LOG_WITH_STREAM() macros are all compiled in release bu...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2016-09-19 11:05 PDT by Keith Rollin
Modified: 2016-09-19 15:01 PDT (History)
3 users (show)

See Also:

Patch (3.46 KB, patch)
2016-09-19 13:44 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2016-09-19 11:05:42 PDT
After https://trac.webkit.org/changeset/205275, all LOG_WITH_STREAM macros are now enabled in release builds, because LogMacros.h has:

#define LOG_WITH_STREAM(.....)

LOG() is OK, so we should make them match.

Comment 1 Keith Rollin 2016-09-19 11:45:04 PDT
Disable those macros in RELEASE_LOG_DISABLED mode. With that disabled, there were a couple of downstream effects. First, GraphicsContextCG.cpp would no longer access a local variable in release mode, so that variable needed to be conditionally defined. Second, the inclusion of logFunctionResult also needed to be fiddled with.
Comment 2 Keith Rollin 2016-09-19 13:44:49 PDT
Created attachment 289253 [details]
Comment 3 WebKit Commit Bot 2016-09-19 15:01:41 PDT
Comment on attachment 289253 [details]

Clearing flags on attachment: 289253

Committed r206120: <http://trac.webkit.org/changeset/206120>
Comment 4 WebKit Commit Bot 2016-09-19 15:01:45 PDT
All reviewed patches have been landed.  Closing bug.