https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/29782/steps/API%20tests/logs/stdio [----------] 2 tests from EWK2ContextMenuTest [ RUN ] EWK2ContextMenuTest.ewk_context_menu_item_select ERR<17602>:ecore_evas modules/ecore_evas/engines/x/ecore_evas_x.c:4584 ecore_evas_gl_x11_options_new_internal() evas_engine_info_set() init engine 'opengl_x11' failed. ERR<17602>:evas_main lib/evas/canvas/evas_gl.c:151 evas_gl_new() Evas GL engine not available. ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:202: Failure Value of: waitUntilLoadFinished() Actual: false Expected: true [ FAILED ] EWK2ContextMenuTest.ewk_context_menu_item_select (10152 ms) [ RUN ] EWK2ContextMenuTest.ewk_context_menu_custom_items ERR<17602>:ecore_evas modules/ecore_evas/engines/x/ecore_evas_x.c:4584 ecore_evas_gl_x11_options_new_internal() evas_engine_info_set() init engine 'opengl_x11' failed. ERR<17602>:evas_main lib/evas/canvas/evas_gl.c:151 evas_gl_new() Evas GL engine not available. [ OK ] EWK2ContextMenuTest.ewk_context_menu_custom_items (228 ms) [----------] 2 tests from EWK2ContextMenuTest (10380 ms total) [----------] Global test environment tear-down [==========] 2 tests from 1 test case ran. (10380 ms total) [ PASSED ] 1 test. [ FAILED ] 1 test, listed below: [ FAILED ] EWK2ContextMenuTest.ewk_context_menu_item_select
Created attachment 289298 [details] Patch
Comment on attachment 289298 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289298&action=review LGTM with my comment. > Source/WebKit2/ChangeLog:9 > + to wait to finish the loading. I change the codes to finish the test when "testFinished" is true. It seems to me that this description is unclear to me. I revise it as below, ewk_context_menu_item_select has been waited until test page loading is finished, but it is unnecessary to wait the loading is finished. It would be good to pass if *testFinished* flag is true. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:200 > + ewkViewClass()->context_menu_hide = finishTest; Nice catch. We have missed to do it. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:205 > + testFinished = false; ditto.
Created attachment 289413 [details] Patch
(In reply to comment #2) > Comment on attachment 289298 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=289298&action=review > > LGTM with my comment. > > > Source/WebKit2/ChangeLog:9 > > + to wait to finish the loading. I change the codes to finish the test when "testFinished" is true. > > It seems to me that this description is unclear to me. I revise it as below, > > ewk_context_menu_item_select has been waited until test page loading is > finished, but it is unnecessary > to wait the loading is finished. It would be good to pass if *testFinished* > flag is true. Thanks Gyuyoung, I will try to write down a clear description.
Comment on attachment 289413 [details] Patch Clearing flags on attachment: 289413 Committed r206194: <http://trac.webkit.org/changeset/206194>
All reviewed patches have been landed. Closing bug.