Bug 162115 – Web Inspector: Color picker in Style sidebar stops working after 1st color change

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
Color picker in Style sidebar stops working after 1st color change

Steps to Reproduce:
1. Inspect an element with a color property
2. Click color swatch to bring up the editor
3. Change color once
  => CSS updates, page updates
4. Change color again
  => Nothing happens.

Notes:
- Sequence of events seems to be:
  => InlineSwatch ValueChanged
    => codeMirror.replaceRange(...)
      => codeMirror content changed
        => update backend (inform of style changes)
        => domnodestyles update PropertiesChanged
          => CSSStyleDeclarationTextEditor _propertiesChanged
            => clear markers + create new inline swatches

When new inline swatches are created the UI cannot recover. The popover is orphaned. It sends events but the CSSStyleDeclarationTextEditor has nothing to update, and the original inline swatch's elements have been removed and replaced so the updates have no visible changes.

Simple solution may be to just not recreate markers when actively editing.

[Radar WebKit Bug Importer]

<rdar://problem/28349875>

[Joseph Pecoraro]

Created attachment 289163 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 289163 [details]
[PATCH] Proposed Fix

r=me

Man, we need UI tests.

[WebKit Commit Bot]

Comment on attachment 289163 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 289163

Committed r206092: <http://trac.webkit.org/changeset/206092>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.