Bug 162113 – Web Inspector: Scope sidebar shows "Closure" instead of "Local" when paused in anonymous function

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
Scope sidebar shows "Closure" instead of "Local" when paused in anonymous function

Test:
<script>
(function f() {
    let a;
    var x;
    debugger;
})();
</script>

Steps to Reproduce:
1. Inspect test page
2. Reload to trigger pause
3. Show Scope sidebar
  => Top scope says "Closure Variables" but should say "Local Variables"

Notes:
- We are comparing the empty string function name against `null` when merging scopes and trying to detect the top as Local

[Radar WebKit Bug Importer]

<rdar://problem/28348954>

[Joseph Pecoraro]

Created attachment 289160 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 289160 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=289160&action=review

r=me

> LayoutTests/inspector/debugger/paused-scopes.html:101
> +            WebInspector.debuggerManager.singleFireEventListener(WebInspector.DebuggerManager.Event.CallFramesDidChange, (event) => {

Could probably use .awaitEvent(...).then here.

[WebKit Commit Bot]

Comment on attachment 289160 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 289160

Committed r206105: <http://trac.webkit.org/changeset/206105>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.