Bug 162112 - Add a unit test covering <https://trac.webkit.org/changeset/205983>
Summary: Add a unit test covering <https://trac.webkit.org/changeset/205983>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-16 21:05 PDT by Wenson Hsieh
Modified: 2016-09-22 09:14 PDT (History)
4 users (show)

See Also:


Attachments
Patch (15.66 KB, patch)
2016-09-16 21:09 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Refactored TestWKWebView to be hosted in a key window. (22.48 KB, patch)
2016-09-17 11:23 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
s/NSWindowStyleMaskBorderless/NSBorderlessWindowMask (22.47 KB, patch)
2016-09-17 11:45 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Rewrote 2 disabled CandidateTests as WK2 tests (33.30 KB, patch)
2016-09-18 12:27 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2016-09-16 21:05:23 PDT
Add a unit test covering https://bugs.webkit.org/show_bug.cgi?id=162008
Comment 1 Wenson Hsieh 2016-09-16 21:09:32 PDT
Created attachment 289158 [details]
Patch
Comment 2 Tim Horton 2016-09-17 01:21:10 PDT
Comment on attachment 289158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289158&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:33
> +#import <AppKit/NSTouchDevice_Private.h>

I don't think you can do that.
Comment 3 Wenson Hsieh 2016-09-17 11:21:26 PDT
Comment on attachment 289158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289158&action=review

>> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:33
>> +#import <AppKit/NSTouchDevice_Private.h>
> 
> I don't think you can do that.

Indeed -- it seems I forgot to remove this after debugging. I'll upload a v2 (there are some other issues I addressed, such as +[CandidateTestWebView setUpWithFrame:] not actually using its params).
Comment 4 Wenson Hsieh 2016-09-17 11:23:34 PDT
Created attachment 289174 [details]
Refactored TestWKWebView to be hosted in a key window.
Comment 5 Wenson Hsieh 2016-09-17 11:45:23 PDT
Created attachment 289176 [details]
s/NSWindowStyleMaskBorderless/NSBorderlessWindowMask
Comment 6 Wenson Hsieh 2016-09-18 12:27:12 PDT
Created attachment 289210 [details]
Rewrote 2 disabled CandidateTests as WK2 tests
Comment 7 Beth Dakin 2016-09-19 17:06:38 PDT
Comment on attachment 289210 [details]
Rewrote 2 disabled CandidateTests as WK2 tests

Looks good!
Comment 8 WebKit Commit Bot 2016-09-19 18:04:53 PDT
Comment on attachment 289210 [details]
Rewrote 2 disabled CandidateTests as WK2 tests

Clearing flags on attachment: 289210

Committed r206135: <http://trac.webkit.org/changeset/206135>
Comment 9 WebKit Commit Bot 2016-09-19 18:04:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Wenson Hsieh 2016-09-20 08:10:13 PDT
Reopening to attach new patch.
Comment 11 Wenson Hsieh 2016-09-22 09:14:10 PDT
I must have accidentally reopened this. Closing.