Add a unit test covering https://bugs.webkit.org/show_bug.cgi?id=162008
Created attachment 289158 [details] Patch
Comment on attachment 289158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289158&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:33 > +#import <AppKit/NSTouchDevice_Private.h> I don't think you can do that.
Comment on attachment 289158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289158&action=review >> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:33 >> +#import <AppKit/NSTouchDevice_Private.h> > > I don't think you can do that. Indeed -- it seems I forgot to remove this after debugging. I'll upload a v2 (there are some other issues I addressed, such as +[CandidateTestWebView setUpWithFrame:] not actually using its params).
Created attachment 289174 [details] Refactored TestWKWebView to be hosted in a key window.
Created attachment 289176 [details] s/NSWindowStyleMaskBorderless/NSBorderlessWindowMask
Created attachment 289210 [details] Rewrote 2 disabled CandidateTests as WK2 tests
Comment on attachment 289210 [details] Rewrote 2 disabled CandidateTests as WK2 tests Looks good!
Comment on attachment 289210 [details] Rewrote 2 disabled CandidateTests as WK2 tests Clearing flags on attachment: 289210 Committed r206135: <http://trac.webkit.org/changeset/206135>
All reviewed patches have been landed. Closing bug.
Reopening to attach new patch.
I must have accidentally reopened this. Closing.