Bug 162107 - Web Replay: teach the replay inputs generator to encode and decode OptionSet<T>
Summary: Web Replay: teach the replay inputs generator to encode and decode OptionSet<T>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-09-16 17:29 PDT by BJ Burg
Modified: 2016-09-19 10:18 PDT (History)
12 users (show)

See Also:

Attachments
Proposed Fix (29.45 KB, patch)
2016-09-16 17:47 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-09-16 17:29:46 PDT 
Hehe.
Comment 1 BJ Burg 2016-09-16 17:47:35 PDT 
Created attachment 289152 [details]
Proposed Fix
Comment 2 WebKit Commit Bot 2016-09-16 17:50:13 PDT 
This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)
Comment 3 WebKit Commit Bot 2016-09-16 17:50:22 PDT 
Attachment 289152 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.h:75:  "virtual" is redundant since function is already declared as "final"  [readability/inheritance] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2016-09-19 10:18:45 PDT 
Comment on attachment 289152 [details]
Proposed Fix

Clearing flags on attachment: 289152

Committed r206099: <http://trac.webkit.org/changeset/206099>
Comment 5 WebKit Commit Bot 2016-09-19 10:18:48 PDT 
All reviewed patches have been landed.  Closing bug.