Bug 162099 – Web Inspector: adopt Object.awaitEvent in LayoutTests/inspector/network

• Status: REOPENED
• Component: Web Inspector

[Devin Rousso]

.

[Radar WebKit Bug Importer]

<rdar://problem/28346596>

[Devin Rousso]

Created attachment 289137 [details]
Patch

[Blaze Burg]

Comment on attachment 289137 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 289137 [details]
Patch

Clearing flags on attachment: 289137

Committed r206112: <http://trac.webkit.org/changeset/206112>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

Reverted r206112 for reason:

This change made inspector/network/xhr-json-blob-has-content.html very flaky.

Committed r206263: <http://trac.webkit.org/changeset/206263>

[Ryan Haddad]

*** Bug 162360 has been marked as a duplicate of this bug. ***

[Joseph Pecoraro]

Comment on attachment 289137 [details]
Patch

I really find these changes much harder to read then the original test. The original test read:

  "do this, cause and do this"

Now they read:

  "prepare for some stuff, do this"

Am I alone in this?

[Blaze Burg]

(In reply to comment #8)
> Comment on attachment 289137 [details]
> Patch
> 
> I really find these changes much harder to read then the original test. The
> original test read:
> 
>   "do this, cause and do this"
> 
> Now they read:
> 
>   "prepare for some stuff, do this"
> 
> Am I alone in this?

I think so? It's not always possible to make the test linear like that, then the promise chain kicks off at some random awkward part of the test. I prefer making the test explicitly event-based with the trigger at the end rather than implicitly depending on evaluating script being asynchronous. That way, the test is structured the same way (prep + trigger) whether the initial part of the promise chain is triggered by synchronous events from WI.Object or from async backend commands that have responses or cause events.