162097 – Web Inspector: Zooming affects both inspector and page

Bug 162097 - Web Inspector: Zooming affects both inspector and page

Summary: Web Inspector: Zooming affects both inspector and page

Status:	RESOLVED WORKSFORME

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (show other bugs)
Version:	Safari Technology Preview
Hardware:	All All

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2016-09-16 15:59 PDT by Stefan Arentz
Modified:	2017-05-05 16:42 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Stefan Arentz 2016-09-16 15:59:19 PDT

Looks like Command-Minus is hooked up to the inspector but Command-Plus goes to the web page.

STR:

Load some web page.

Open the inspector.

Hit Command-Minus and observe that it zooms the Inspector out.

Hit Command-Plus and observe that it zooms the page in.


You can get the inspector back to normal zoom level with Command-0 as an escape hatch.

Comment 1 Radar WebKit Bug Importer 2016-09-16 15:59:33 PDT

<rdar://problem/28345877>

Comment 2 BJ Burg 2016-09-16 16:10:18 PDT

I cannot reproduce this. Please include some things to help diagnose:

 - OS version
 - WebKit / Safari version
 - do you have any conflicting system keybindings?
 - test page where this happens
 - a screenshot or video

Comment 3 Timothy Hatcher 2016-09-16 16:10:59 PDT

This should have been fixed by bug 157234. Is the keyboard is non-US?

Comment 4 Devin Rousso 2016-09-16 16:59:24 PDT

I was able to reproduce this when holding the Shift or Option keys in addition to Command-Minus and Command-Plus.

Comment 5 Stefan Arentz 2016-09-17 13:00:25 PDT

(In reply to comment #4)
> I was able to reproduce this when holding the Shift or Option keys in
> addition to Command-Minus and Command-Plus.

Yeah that is where the confusion comes from.

It seems Safari recognizes the following to zoom web content out/in:

Command-Minus Command-Underscore (out)
Command-Plus Command-Equals (in)

But when the web inspector is in focus, the inspector is changed with:

Command-Minus Command-Underscore
Command-Equals

While Command-+ is handled by the web content.

So there is an inconsistency. Not major, but annoying enogh for those of us who have Command-Plus in our muscle memory.

Comment 6 Stefan Arentz 2016-09-17 13:01:55 PDT

I'm on Sierra GM, Safari Technology Preview 13 (Version 10.0 (12602.1.50.0.8)). Same thing with the Safari version that ships with Sierra GM.

Comment 7 Stefan Arentz 2016-09-17 15:12:33 PDT

(In reply to comment #3)
> This should have been fixed by bug 157234. Is the keyboard is non-US?

This is an en-US keyboard.

Comment 8 BJ Burg 2016-09-17 16:10:06 PDT

Okay, that makes sense I guess. Not all people use QWERTY / default keybindings. For example, some people don't even have a + key, or the unshifted version is a different character. I think we have enough information to reproduce the bug now.

Comment 9 BJ Burg 2017-05-05 16:42:25 PDT

I cannot reproduce this any more. Please write in if it is still an issue on Safari Technology Preview 29+.