Bug 162096 - Add size assert for RenderElement
Summary: Add size assert for RenderElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 162110 162229
Blocks:
  Show dependency treegraph
 
Reported: 2016-09-16 15:53 PDT by Antti Koivisto
Modified: 2016-09-19 15:14 PDT (History)
5 users (show)

See Also:


Attachments
patch (2.21 KB, patch)
2016-09-16 15:57 PDT, Antti Koivisto
commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch (2.26 KB, patch)
2016-09-19 14:26 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-09-16 15:53:50 PDT
prevent accidental growth
Comment 1 Antti Koivisto 2016-09-16 15:57:35 PDT
Created attachment 289125 [details]
patch
Comment 2 WebKit Commit Bot 2016-09-16 16:35:42 PDT
Comment on attachment 289125 [details]
patch

Clearing flags on attachment: 289125

Committed r206055: <http://trac.webkit.org/changeset/206055>
Comment 3 WebKit Commit Bot 2016-09-16 16:35:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Commit Bot 2016-09-16 19:39:44 PDT
Re-opened since this is blocked by bug 162110
Comment 5 Antti Koivisto 2016-09-19 12:01:32 PDT
Comment on attachment 289125 [details]
patch

Trying to land again.
Comment 6 WebKit Commit Bot 2016-09-19 12:04:08 PDT
Comment on attachment 289125 [details]
patch

Rejecting attachment 289125 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 289125, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2107071
Comment 7 Antti Koivisto 2016-09-19 14:26:56 PDT
Created attachment 289255 [details]
patch

this should work everywhere
Comment 8 WebKit Commit Bot 2016-09-19 15:14:20 PDT
Comment on attachment 289255 [details]
patch

Clearing flags on attachment: 289255

Committed r206121: <http://trac.webkit.org/changeset/206121>
Comment 9 WebKit Commit Bot 2016-09-19 15:14:25 PDT
All reviewed patches have been landed.  Closing bug.