Bug 162078 – [CSS Parser] Get CSSPropertyParserHelpers.cpp compiling

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Hyatt]

[CSS Parser] Get CSSPropertyParserHelpers.cpp compiling

[Dave Hyatt]

Created attachment 289087 [details]
Patch

[WebKit Commit Bot]

Attachment 289087 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSCalculationValue.cpp:609:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/css/parser/CSSParserIdioms.h:69:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/css/CSSPrimitiveValue.h:159:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/CSSPrimitiveValue.h:165:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:579:  'result' is incorrectly named. It should be named 'protector' or 'protectedNullptr'.  [readability/naming/protected] [4]
ERROR: Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:998:  'result' is incorrectly named. It should be named 'protector' or 'protectedNullptr'.  [readability/naming/protected] [4]
Total errors found: 6 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 289090 [details]
Patch

[WebKit Commit Bot]

Attachment 289090 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSPrimitiveValue.h:159:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/CSSPrimitiveValue.h:165:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 289092 [details]
Patch

[WebKit Commit Bot]

Attachment 289092 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSPrimitiveValue.h:159:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/CSSPrimitiveValue.h:165:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 289094 [details]
Patch

[WebKit Commit Bot]

Attachment 289094 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSPrimitiveValue.h:159:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/CSSPrimitiveValue.h:165:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

Comment on attachment 289094 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289094&action=review

> Source/WebCore/css/CSSCalculationValue.cpp:900
> +    return expression ? adoptRef(new CSSCalcValue(expression.releaseNonNull(), range != ValueRangeAll)) : nullptr;
> +
> +}

Nit: extra blank line

[Dave Hyatt]

Landed in r206043.