Bug 162061 - [GTK] Move the rendering of auth dialog shadow to the auth dialog widget
Summary: [GTK] Move the rendering of auth dialog shadow to the auth dialog widget
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 161530
  Show dependency tree / graph
 
Reported: 2016-09-16 09:41 PDT by Carlos Garcia Campos
Modified: 2016-09-17 01:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.06 KB, patch)
2016-09-16 09:46 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-09-16 09:41:11 PDT 
Instead of rendering the shadow in the web view, we can let the auth dialog do it. This fixes the rendering of the shadow in Wayland when using gdk_cairo_draw_from_gl().
Comment 1 Carlos Garcia Campos 2016-09-16 09:46:11 PDT 
Created attachment 289065 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-16 09:48:20 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Michael Catanzaro 2016-09-16 10:28:24 PDT 
Comment on attachment 289065 [details]
Patch

Wait for EWS
Comment 4 Carlos Garcia Campos 2016-09-17 01:36:39 PDT 
Committed r206067: <http://trac.webkit.org/changeset/206067>