Bug 162052 – [media-source] Fix imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-audio-bitrate.html

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[media-source] Fix imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-audio-bitrate.html

[Jer Noble]

Created attachment 289046 [details]
Patch

[Jer Noble]

Created attachment 289079 [details]
Patch

[Brent Fulgham]

Comment on attachment 289079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289079&action=review

The change seems fine, though I'm curious if we can trust the rest of the trackBuffer's state if the 'lastEnqueuedPresentationTime' is invalid.

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:817
> +        if (trackBuffer.lastEnqueuedPresentationTime.isValid() && currentMediaTime < trackBuffer.lastEnqueuedPresentationTime) {

Is it safe to keep using the trackBuffer if the last enqueued presentation time is garbage? Would it be better to return or something? Or is that a 'normal' state for things to get into?

[Jer Noble]

(In reply to comment #3)
> Comment on attachment 289079 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=289079&action=review
> 
> The change seems fine, though I'm curious if we can trust the rest of the
> trackBuffer's state if the 'lastEnqueuedPresentationTime' is invalid.
> 
> > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:817
> > +        if (trackBuffer.lastEnqueuedPresentationTime.isValid() && currentMediaTime < trackBuffer.lastEnqueuedPresentationTime) {
> 
> Is it safe to keep using the trackBuffer if the last enqueued presentation
> time is garbage? Would it be better to return or something? Or is that a
> 'normal' state for things to get into?

That's a normal state; the lastEnqueuedPresentationTime starts out as invalid, and can get reset to invalid during the normal course of events.
Thanks!

[WebKit Commit Bot]

Comment on attachment 289079 [details]
Patch

Clearing flags on attachment: 289079

Committed r206037: <http://trac.webkit.org/changeset/206037>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.