Bug 162048 - Support transitions/animations of background-position with right/bottom-relative values
Summary: Support transitions/animations of background-position with right/bottom-relat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: WebExposed
: 162881 (view as bug list)
Depends on: 163097
Blocks:
  Show dependency treegraph
 
Reported: 2016-09-15 22:39 PDT by Simon Fraser (smfr)
Modified: 2017-03-08 15:51 PST (History)
7 users (show)

See Also:


Attachments
Patch (30.71 KB, patch)
2016-09-15 22:44 PDT, Simon Fraser (smfr)
dino: review+
Details | Formatted Diff | Diff
For EWS (34.98 KB, patch)
2016-10-01 16:55 PDT, Simon Fraser (smfr)
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.25 MB, application/zip)
2016-10-01 17:59 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews103 for mac-yosemite (876.58 KB, application/zip)
2016-10-01 18:03 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-09-15 22:39:15 PDT
Support transitions/animations of background-position with right/bottom-relative values
Comment 1 Simon Fraser (smfr) 2016-09-15 22:44:24 PDT
Created attachment 289034 [details]
Patch
Comment 2 Dean Jackson 2016-09-16 16:25:57 PDT
Comment on attachment 289034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289034&action=review

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1051
> +            // Convert the right/bottom into a calc expression,

Nit: ,
Comment 3 Simon Fraser (smfr) 2016-10-01 16:55:16 PDT
Created attachment 290449 [details]
For EWS
Comment 4 Build Bot 2016-10-01 17:59:05 PDT
Comment on attachment 290449 [details]
For EWS

Attachment 290449 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2184761

New failing tests:
fast/shapes/shape-outside-floats/shape-outside-animation.html
Comment 5 Build Bot 2016-10-01 17:59:08 PDT
Created attachment 290454 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-10-01 18:03:32 PDT
Comment on attachment 290449 [details]
For EWS

Attachment 290449 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2184778

New failing tests:
fast/shapes/shape-outside-floats/shape-outside-animation.html
Comment 7 Build Bot 2016-10-01 18:03:35 PDT
Created attachment 290455 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Simon Fraser (smfr) 2016-10-01 18:08:43 PDT
https://trac.webkit.org/changeset/206713
Comment 9 WebKit Commit Bot 2016-10-06 19:33:25 PDT
Re-opened since this is blocked by bug 163097
Comment 10 Ryan Haddad 2016-10-10 16:34:19 PDT
*** Bug 162881 has been marked as a duplicate of this bug. ***
Comment 11 Simon Fraser (smfr) 2017-03-08 15:51:16 PST
Re-landed in https://trac.webkit.org/r213603