Bug 162046 - Window's pageXOffset / pageYOffset attributes should be replaceable
Summary: Window's pageXOffset / pageYOffset attributes should be replaceable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://drafts.csswg.org/cssom-view/#...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-09-15 19:02 PDT by Chris Dumez
Modified: 2016-09-19 13:38 PDT (History)
9 users (show)

See Also:

Attachments
Patch (9.59 KB, patch)
2016-09-15 19:33 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (10.86 KB, patch)
2016-09-19 12:23 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-09-15 19:02:38 PDT 
Window's pageXOffset / pageYOffset attributes should be replaceable as per:
- https://drafts.csswg.org/cssom-view/#extensions-to-the-window-interface

Firefox agrees with the specification.
Comment 1 Chris Dumez 2016-09-15 19:33:22 PDT 
Created attachment 289028 [details]
Patch
Comment 2 Darin Adler 2016-09-19 11:12:29 PDT 
Comment on attachment 289028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289028&action=review

Please fix the GTK build. WebKitDOMDOMWindow.cpp has calls to these functions.

> Source/WebCore/page/DOMWindow.idl:98
> +    // FIXME: The following attributes should be double.

Now that we don’t have non-JavaScript bindings to consider, changing these to double should be an easier thing to do, in fact I’m not sure it will actually have any observable effect. What are we waiting for to make that change?
Comment 3 Chris Dumez 2016-09-19 12:23:59 PDT 
Created attachment 289247 [details]
Patch
Comment 4 WebKit Commit Bot 2016-09-19 13:38:00 PDT 
Comment on attachment 289247 [details]
Patch

Clearing flags on attachment: 289247

Committed r206109: <http://trac.webkit.org/changeset/206109>
Comment 5 WebKit Commit Bot 2016-09-19 13:38:06 PDT 
All reviewed patches have been landed.  Closing bug.