Summary; Add test coverage for all array utility functions. The following lack tests: Array.prototype.lastValue Array.prototype.remove Array.prototype.toggleIncludes Array.prototype.insertAtIndex Array.prototype.keySet
<rdar://problem/28330846>
Created attachment 289024 [details] [Patch] Proposed Fix
Comment on attachment 289024 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=289024&action=review r=me! > LayoutTests/inspector/unit-tests/array-utilities.html:129 > + test: () => { Style: We've been simplifying the syntax here to method syntax. test() { > LayoutTests/inspector/unit-tests/array-utilities.html:179 > + let arr2 = [1, 2, 3]; > + arr2.insertAtIndex("x", 0); > + InspectorTest.expectShallowEqual(arr2, ["x", 1, 2, 3], "insertAtIndex with index zero should insert at the beginning."); I'd like a test that inserts in the middle (any index such that 0 < index < length): insertAtIndex("x", 2)
Created attachment 289123 [details] [Patch] For Landing
Comment on attachment 289123 [details] [Patch] For Landing Rejecting attachment 289123 [details] from commit-queue. New failing tests: inspector/unit-tests/array-utilities.html Full output: http://webkit-queues.webkit.org/results/2090758
Created attachment 289136 [details] Archive of layout-test-results from webkit-cq-01 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 289209 [details] Patch
Comment on attachment 289209 [details] Patch Clearing flags on attachment: 289209 Committed r206085: <http://trac.webkit.org/changeset/206085>
All reviewed patches have been landed. Closing bug.