RESOLVED WONTFIX 162034
No Sample on timeout for EWS bots 
https://bugs.webkit.org/show_bug.cgi?id=162034
Summary No Sample on timeout for EWS bots
Jonathan Bedard
Reported 2016-09-15 14:43:14 PDT
EWS bots throw away their results, running sample or spindump when a test times out is a waste of time.
Attachments
Patch (2.77 KB, patch)
2016-09-15 14:44 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2016-09-15 14:44:55 PDT
Created attachment 289002 [details] Patch
Alexey Proskuryakov
Comment 2 2016-09-15 15:56:55 PDT
Comment on attachment 289002 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289002&action=review > Tools/Scripts/webkitpy/tool/steps/runtests.py:121 > + "--no-sample-on-timeout", Where does this code get run? E.g., will this change what happens when running run-webkit-tests locally.
Jonathan Bedard
Comment 3 2016-09-16 08:12:08 PDT
Comment on attachment 289002 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289002&action=review >> Tools/Scripts/webkitpy/tool/steps/runtests.py:121 >> + "--no-sample-on-timeout", > > Where does this code get run? E.g., will this change what happens when running run-webkit-tests locally. My understanding of this code is that it only runs on the EWS bots. It is possible that other code-paths use this, but I do know that locally this won't change anything (Safari opens when locally running unless --no-show-results is used, if local runs were using this setting Safari would not open after running run-webkit-tests) and that build-bots use the configuration in master.cfg, which is independent of this code-path (master.cfg uses --no-show-results as well, and we don't double command arguments)
Note You need to log in before you can comment on or make changes to this bug.