Bug 162027 – Web Inspector: Include JavaScript completion for ES6 keywords and global variables

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
Include JavaScript completion for ES6 keywords and global variables.

Typing "cl" in the console should suggest "class" as an autocompletion suggestion.

Same for a bunch of other ES6 keywords (yield, static, extends, super).

Steps to Reproduce:
1. js> cl|
  => expected "class"
2. js> var myGlobalVariable; my|
  => expected "myGlobalVariable"

[Joseph Pecoraro]

Created attachment 288983 [details]
[PATCH] Proposed Fix

Heh, `let` is another one we aren't completing!

[Blaze Burg]

Comment on attachment 288983 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=288983&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:603
> +        var allKeywords = [

Nit: let

[WebKit Commit Bot]

Comment on attachment 288983 [details]
[PATCH] Proposed Fix

Rejecting attachment 288983 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 288983, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ing rebase:
:040000 040000 77907c2c86f9eda38945095760db12aafb727120 009c246b407568eae12025fa3be9896237e78514 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/2083111

[Joseph Pecoraro]

<https://trac.webkit.org/changeset/206015>