Bug 162017 – [GTK] Ping attribute tests have been timeout since r204720

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Javier Fernandez]

Need to investigate why below tests are timeout.

  http/tests/navigation/ping-attribute/anchor-cookie.html [ Timeout ]
  http/tests/navigation/ping-attribute/anchor-cross-origin-from-https.html [ Timeout ]
  http/tests/navigation/ping-attribute/anchor-cross-origin.html [ Timeout ]
  http/tests/navigation/ping-attribute/anchor-same-origin.html [ Timeout ]
  http/tests/navigation/ping-attribute/area-cookie.html [ Timeout ]
  http/tests/navigation/ping-attribute/area-cross-origin-from-https.html [ Timeout ]
  http/tests/navigation/ping-attribute/area-cross-origin.html [ Timeout ]
  http/tests/navigation/ping-attribute/area-same-origin.html [ Timeout ]

[Miguel Gomez]

http/tests/navigation/ping-attribute/anchor-ping-and-follow-redirect-when-sending-ping.html

is timing out as well. Updating expectations.

[Alicia Boya García]

Started crashing at some point since r224584-224585.

[Alicia Boya García]

Failing since r232991:r232999

[Alicia Boya García]

(In reply to Alicia Boya García from comment #3)
> Failing since r232991:r232999

That only applies to http/tests/navigation/ping-attribute/area-cross-origin-from-https.html

[Miguel Gomez]

These tests are now crashing as reported in bug 200534. Adding the crash expectation besides the existent one so we can go back to this when the crash is fixed.

http/tests/navigation/ping-attribute/anchor-cookie.html [ Crash ]
http/tests/navigation/ping-attribute/anchor-cross-origin-from-https.html [ Crash ]
http/tests/navigation/ping-attribute/anchor-cross-origin.html [ Crash ]
http/tests/navigation/ping-attribute/area-cookie.html [ Crash ]
http/tests/navigation/ping-attribute/area-cross-origin.html [ Crash ]
http/tests/navigation/ping-attribute/area-same-origin.html [ Crash ]
http/tests/navigation/ping-attribute/anchor-ping-and-follow-redirect-when-sending-ping.html [ Crash ]
http/tests/navigation/ping-attribute/area-cross-origin-from-https.html [ Crash ]

[Diego Pino]

I think the reason why these tests are crashing is because there's no implementation of singleTapAtPoint in GTK's WKTR.

https://webkit-search.igalia.com/webkit/source/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h#150

Crash-log:

Thread 1 (Thread 0x7fe3e19e9e80 (LWP 227)):
#0  0x00007fe3e80a97ee in WTFCrash () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#1  0x000055899ec0a679 in  ()
#2  0x000055899ec46f30 in WTR::JSUIScriptController::singleTapAtPoint(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) ()
#3  0x00007fe3e7136eca in long JSC::APICallbackFunction::call<JSC::JSCallbackFunction>(JSC::JSGlobalObject*, JSC::CallFrame*) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#4  0x00007fe303fff027 in  ()
#5  0x00007fff913b2fd0 in  ()
#6  0x00007fe3e70b396d in llint_op_call () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#7  0x0000000000000000 in  ()

STDERR:
STDERR: warning: core file may not match specified executable file.
STDERR: 1   0x7fe3e80a97e9 WTFCrash
STDERR: 2   0x55899ec0a679 /app/webkit/WebKitBuild/Release/bin/WebKitTestRunner(+0x17679) [0x55899ec0a679]
STDERR: 3   0x55899ec46f30 /app/webkit/WebKitBuild/Release/bin/WebKitTestRunner(+0x53f30) [0x55899ec46f30]
STDERR: 4   0x7fe3e7136eca long JSC::APICallbackFunction::call<JSC::JSCallbackFunction>(JSC::JSGlobalObject*, JSC::CallFrame*)
STDERR: 5   0x7fe303fff027 [0x7fe303fff027]

Marking tests as skip until there's an implementation of singleTapAtPoint for GTK WKTR.

[Carlos Garcia Campos]

That's weird because singleTapAtPoint is only implemented (and I think expected to be used) by iOS.

[Carlos Garcia Campos]

    let supportsTouchEvents = "TouchEvent" in window;
    if (supportsTouchEvents && window.testRunner && testRunner.runUIScript)
        testRunner.runUIScript("(function() { uiController.singleTapAtPoint(" + x + ", " + y + ", function() { /* Do nothing */ }); })();", function() { /* Do nothing */ });
    else if (window.eventSender) {

I guess that's the problem, they way it's detecting if touch is supported.

[Carlos Garcia Campos]

I think checking ontouchstart instead of TouchEvent would work because ontouchstart is only added when untimeEnabledFeatures::sharedFeatures().touchEventsEnabled() is true.

[Carlos Garcia Campos]

*** Bug 177941 has been marked as a duplicate of this bug. ***

[Carlos Garcia Campos]

Created attachment 402271 [details]
Patch

[Carlos Garcia Campos]

Committed r263343: <https://trac.webkit.org/changeset/263343>