Bug 162007 - Use efficient iterators in URLParser
Summary: Use efficient iterators in URLParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-14 22:16 PDT by Alex Christensen
Modified: 2016-09-15 11:14 PDT (History)
0 users

See Also:


Attachments
Patch (34.66 KB, patch)
2016-09-14 22:24 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (34.76 KB, patch)
2016-09-14 23:26 PDT, Alex Christensen
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-09-14 22:16:03 PDT
Use efficient iterators in URLParser
Comment 1 Alex Christensen 2016-09-14 22:24:55 PDT
Created attachment 288928 [details]
Patch
Comment 2 Alex Christensen 2016-09-14 23:26:43 PDT
Created attachment 288930 [details]
Patch
Comment 3 Alex Christensen 2016-09-15 09:02:32 PDT
Before this patch, URLParser is about 2.05x as slow as URL::parse.
After this patch, URLParser is about 1.55x as slow as URL::parse.
Comment 4 Alex Christensen 2016-09-15 10:14:28 PDT
On my computer this increases the binary size of a release build of WebCore (which is about 44MB) by about 15KB.
Comment 5 Alex Christensen 2016-09-15 11:14:28 PDT
http://trac.webkit.org/changeset/205986