RESOLVED FIXED162004
Move text decoration style computation from RenderObject to TextDecorationPainter 
https://bugs.webkit.org/show_bug.cgi?id=162004
Summary Move text decoration style computation from RenderObject to TextDecorationPai...
Antti Koivisto
Reported 2016-09-14 18:43:13 PDT
It is mostly an implementation detail of TextDecorationPainter.
Attachments
patch (19.32 KB, patch)
2016-09-14 18:49 PDT, Antti Koivisto 		zalan: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews117 for mac-yosemite (1.85 MB, application/zip)
2016-09-14 19:39 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews102 for mac-yosemite (1.22 MB, application/zip)
2016-09-14 19:46 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.15 MB, application/zip)
2016-09-14 19:52 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews123 for ios-simulator-elcapitan-wk2 (9.50 MB, application/zip)
2016-09-14 20:01 PDT, Build Bot 		no flags
Details
patch (19.31 KB, patch)
2016-09-15 10:40 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2016-09-14 18:49:19 PDT
Created attachment 288910 [details] patch
Simon Fraser (smfr)
Comment 2 2016-09-14 18:53:48 PDT
Comment on attachment 288910 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=288910&action=review > Source/WebCore/rendering/TextDecorationPainter.cpp:398 > + if (!requestedDecorations) Would prefer a blank line above.
Build Bot
Comment 3 2016-09-14 19:39:41 PDT
Comment on attachment 288910 [details] patch Attachment 288910 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2076236 New failing tests: fast/css/text-decorations-on-first-line-and-containing-block.html
Build Bot
Comment 4 2016-09-14 19:39:46 PDT
Created attachment 288914 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 5 2016-09-14 19:46:37 PDT
Comment on attachment 288910 [details] patch Attachment 288910 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2076294 New failing tests: fast/css/text-decorations-on-first-line-and-containing-block.html
Build Bot
Comment 6 2016-09-14 19:46:40 PDT
Created attachment 288917 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 7 2016-09-14 19:52:00 PDT
Comment on attachment 288910 [details] patch Attachment 288910 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2076310 New failing tests: fast/css/text-decorations-on-first-line-and-containing-block.html
Build Bot
Comment 8 2016-09-14 19:52:03 PDT
Created attachment 288920 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 9 2016-09-14 20:01:40 PDT
Comment on attachment 288910 [details] patch Attachment 288910 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2076311 New failing tests: fast/css/text-decorations-on-first-line-and-containing-block.html
Build Bot
Comment 10 2016-09-14 20:01:43 PDT
Created attachment 288921 [details] Archive of layout-test-results from ews123 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.6
Antti Koivisto
Comment 11 2016-09-15 10:40:39 PDT
Created attachment 288970 [details] patch
Antti Koivisto
Comment 12 2016-09-15 11:14:48 PDT
https://trac.webkit.org/r205985
Note You need to log in before you can comment on or make changes to this bug.