161995 – YARR doesn't check for invalid flags for literal regular expressions

Bug 161995 - YARR doesn't check for invalid flags for literal regular expressions

Summary: YARR doesn't check for invalid flags for literal regular expressions

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	JavaScriptCore (show other bugs)
Version:	Other
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Michael Saboff

URL:
Keywords:	InRadar

Depends on:
Blocks:

Attachments
Patch (4.12 KB, patch) 2016-09-14 15:05 PDT, Michael Saboff	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Saboff 2016-09-14 14:52:45 PDT

A regular expression like /a/Z doesn't create an error.

Comment 1 Michael Saboff 2016-09-14 14:53:27 PDT

<rdar://problem/27975736>

Comment 2 Michael Saboff 2016-09-14 15:03:06 PDT

Note that is is only a problem for literal regular expressions in JavaScript code.  When the new RegExp() constructor is used, the flags are checked.

Comment 3 Michael Saboff 2016-09-14 15:05:25 PDT

Created attachment 288869 [details]
Patch

Comment 4 Mark Lam 2016-09-14 15:11:51 PDT

Comment on attachment 288869 [details]
Patch

r=me

Comment 5 WebKit Commit Bot 2016-09-14 16:20:06 PDT

Comment on attachment 288869 [details]
Patch

Clearing flags on attachment: 288869

Committed r205937: <http://trac.webkit.org/changeset/205937>

Comment 6 WebKit Commit Bot 2016-09-14 16:20:10 PDT

All reviewed patches have been landed.  Closing bug.