Bug 161981 – Cleanup RenderLayer::shouldBeNormalFlowOnly

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

return (renderer().hasOverflowClip()
        || renderer().hasReflection()
        || renderer().hasMask()
        || renderer().isCanvas()
        || renderer().isVideo()
        || renderer().isEmbeddedObject()
        || renderer().isRenderIFrame()
        || (renderer().style().specifiesColumns() && !isRootLayer())
        || renderer().isInFlowRenderFlowThread())
        && !renderer().hasTransformRelatedProperty()
        && !renderer().isPositioned()
        && !needsCompositedScrolling()
        && !renderer().style().hasFlowFrom()
^^ makes it a bit unclear what triggers normal flow only layer.

[zalan]

Created attachment 288848 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 288848 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288848&action=review

> Source/WebCore/rendering/RenderLayer.cpp:6492
> +        || mayCreateGraphicalGroup(renderer);

I think this needs to check willChange()->canCreateStackingContext() but you'll do this in a later patch. Maybe add a FIXME comment.

> Source/WebCore/rendering/RenderLayer.cpp:6517
>          || needsCompositedScrolling()
>          || isolatesBlending()
>          || renderer().hasReflection()

I think these tree are redundant since createsStackingContext() checks them.

[Build Bot]

Comment on attachment 288848 [details]
Patch

Attachment 288848 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2074053

New failing tests:
media/audio-repaint.html

[Build Bot]

Created attachment 288856 [details]
Archive of layout-test-results from ews121 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6

[zalan]

Created attachment 288922 [details]
Patch

[Build Bot]

Comment on attachment 288922 [details]
Patch

Attachment 288922 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2076737

New failing tests:
compositing/overflow/composited-scrolling-creates-a-stacking-container.html
compositing/overflow/automatically-opt-into-composited-scrolling.html

[Build Bot]

Created attachment 288924 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 288922 [details]
Patch

Attachment 288922 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2076744

New failing tests:
compositing/overflow/composited-scrolling-creates-a-stacking-container.html
compositing/overflow/automatically-opt-into-composited-scrolling.html

[Build Bot]

Created attachment 288925 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 288922 [details]
Patch

Attachment 288922 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2076745

New failing tests:
compositing/overflow/composited-scrolling-creates-a-stacking-container.html
compositing/overflow/automatically-opt-into-composited-scrolling.html

[Build Bot]

Created attachment 288926 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[zalan]

Created attachment 288927 [details]
Patch

[zalan]

Created attachment 288953 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 288953 [details]
Patch

Clearing flags on attachment: 288953

Committed r205970: <http://trac.webkit.org/changeset/205970>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.