Bug 161976 – [MediaStream] Minor cleanup

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

- MediaStreamTrackSourcesCallback and SourceInfo aren't used, remove them
- CaptureDeviceManager is used in platform, move them there
- Getting the media device list doesn't need to be asynchronous

[Radar WebKit Bug Importer]

<rdar://problem/28302571>

[Eric Carlson]

Created attachment 288828 [details]
Proposed patch.

[Eric Carlson]

Created attachment 288831 [details]
Proposed patch.

[youenn fablet]

Comment on attachment 288831 [details]
Proposed patch.

So the major point here is to make the retrieval of devices synchronous.
That seems to make sense to me. Maybe this change should be added to the ChangeLog.

I'll finish the review tomorrow but this looks good to me.
The win bot might want some changes to DerivedSources.cpp.

 View in context: https://bugs.webkit.org/attachment.cgi?id=288831&action=review

> Source/WebCore/platform/mediastream/CaptureDevice.h:37
> +    enum SourceKind { Audio, Video };

class enum?

> Source/WebCore/platform/mediastream/CaptureDeviceManager.cpp:2
> + * Copyright (C) 2015 Apple Inc. All rights reserved.

Updating the copyright?

> Source/WebCore/platform/mediastream/CaptureDeviceManager.cpp:45
> +}

In the header?

> Source/WebCore/platform/mediastream/CaptureDeviceManager.h:27
> +#define CaptureDeviceManager_h

pragma.

> Source/WebCore/platform/mediastream/CaptureDeviceManager.h:34
> +#include <wtf/text/WTFString.h>

Probably no need for the last two includes

> Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:44
>  #include "RealtimeMediaSource.h"

Probably this include is not needed

[Eric Carlson]

Committed r205929: https://trac.webkit.org/r205929

[Alex Christensen]

r206024

[Alex Christensen]

http://trac.webkit.org/changeset/206034