Bug 161966 – Web Inspector: The inspector sidebar has weird sub-column sizing issues

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[David Gasperoni]

Created attachment 288822 [details]
The inspector sidebar has weird multi sub-column sizing issues

In the Network panel (maybe others?) the sidebar suffers from a weird sub-column sizing issue. I cannot describe it, I made a 50 seconds screencast that I attached.

[Radar WebKit Bug Importer]

<rdar://problem/28300919>

[David Gasperoni]

Still an issue in Safari Technology Preview release 26.

[Devin Rousso]

Created attachment 305257 [details]
Patch

[Matt Baker]

Created attachment 305260 [details]
[Video] Grid column resize bug

Grid column resize elements are highlighted in green, to illustrate the root of the problem.

Column resizers need to be repositioned after the parent sidebar panel's width is changed.

[Joseph Pecoraro]

Comment on attachment 305257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305257&action=review

> Source/WebInspectorUI/ChangeLog:14
> +        * UserInterface/Views/ComputedStyleDetailsPanel.js:

At a glance this all looks good. Great job finding a lot of the sidebar datagrids. I'd expect one more: ProbeDetailsSidebarPanel -> ProbeSetDetailsSection -> its DataGrid (_dataGrid). Let me know if you need instructions for testing probes.

[Matt Baker]

I think we'll want a different solution in the long term. View.sizeDidChange was intended to be called internally during layout. This could be changed, but that was the original intent. Currently sizeDidChange is called by the View base class when LayoutReason.Resize is passed to needsLayout/updateLayout. We may want to invert this pattern, and instead tell a view that its size has changed, and let it determine whether to cause a layout on itself or its subtree.

View would need to have a flag indicating that it needs to perform a layout whenever it (or its parent) is resized. Like the dirty flag on View, this flag would propagate up the parent path in the view hierarchy, but unlike the dirty flag it would be set once when the view is created, and not change.

I'm not suggesting you start over with this patch, but this should be revisited in the future.

[Devin Rousso]

Created attachment 305515 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 305515 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 305515 [details]
Patch

Clearing flags on attachment: 305515

Committed r214439: <http://trac.webkit.org/changeset/214439>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.