Bug 161950 – [media-source] web-platform-test/media-source/mediasource-remove.html test failing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[media-source] Many web-platform-test/media-source tests fail because audio samples are unexpectedly long

[Jer Noble]

Created attachment 288788 [details]
Patch

[Build Bot]

Comment on attachment 288788 [details]
Patch

Attachment 288788 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2071075

New failing tests:
media/media-source/media-source-end-of-stream-buffered.html

[Build Bot]

Created attachment 288795 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 288788 [details]
Patch

Attachment 288788 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2071078

New failing tests:
media/media-source/media-source-end-of-stream-buffered.html

[Build Bot]

Created attachment 288796 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 288788 [details]
Patch

Attachment 288788 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2071167

New failing tests:
media/media-source/media-source-end-of-stream-buffered.html

[Build Bot]

Created attachment 288799 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Jer Noble]

Created attachment 288864 [details]
Patch

[Eric Carlson]

Comment on attachment 288864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288864&action=review

r=me, assuming the bots are happy with it

> Source/WebCore/Modules/mediasource/MediaSource.cpp:273
> +    auto ranges = buffered();

Nit: you don't need this if time > duration.

> Source/WebCore/Modules/mediasource/MediaSource.cpp:291
> +    auto ranges = buffered();

Ditto.

> Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:175
> +    CMItemCount sampleCount = CMSampleBufferGetNumSamples(m_sample.get());
> +    if (samplesBeforePresentationTime >= sampleCount)
> +        return { this, nullptr };

Is this even possible?

[Jer Noble]

Created attachment 288872 [details]
Patch

[Jer Noble]

(In reply to comment #9)
> Comment on attachment 288864 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=288864&action=review
> 
> r=me, assuming the bots are happy with it
> 
> > Source/WebCore/Modules/mediasource/MediaSource.cpp:273
> > +    auto ranges = buffered();
> 
> Nit: you don't need this if time > duration.

Ok.

> > Source/WebCore/Modules/mediasource/MediaSource.cpp:291
> > +    auto ranges = buffered();
> 
> Ditto.

Ok.

> > Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:175
> > +    CMItemCount sampleCount = CMSampleBufferGetNumSamples(m_sample.get());
> > +    if (samplesBeforePresentationTime >= sampleCount)
> > +        return { this, nullptr };
> 
> Is this even possible?

"==" is definitely possible, but ">" is theoretically not. ">=" is probably overkill, but will still catch some things (like if someone calls `divide(MediaTime::positiveInfiniteTime())`).

[Build Bot]

Comment on attachment 288872 [details]
Patch

Attachment 288872 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2074999

New failing tests:
media/media-source/media-source-monitor-source-buffers.html

[Build Bot]

Created attachment 288891 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 288872 [details]
Patch

Attachment 288872 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2074959

New failing tests:
media/media-source/media-source-monitor-source-buffers.html

[Build Bot]

Created attachment 288892 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 288872 [details]
Patch

Attachment 288872 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2075015

New failing tests:
media/media-source/media-source-monitor-source-buffers.html

[Build Bot]

Created attachment 288893 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Jer Noble]

Created attachment 288929 [details]
Patch

[Jer Noble]

Committed r206001: <http://trac.webkit.org/changeset/206001>

[Ryan Haddad]

imported/w3c/web-platform-tests/media-source/mediasource-play.html and imported/w3c/web-platform-tests/media-source/mediasource-remove.html crash on ASan with this change.

[Jer Noble]

(In reply to comment #20)
> imported/w3c/web-platform-tests/media-source/mediasource-play.html and
> imported/w3c/web-platform-tests/media-source/mediasource-remove.html crash
> on ASan with this change.

Filed <https://bugs.webkit.org/show_bug.cgi?id=162050>.