Bug 161945 – Web Inspector: Call Stack tree in the Debugger sidebar should mark the active call frame

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Summary:
Call Stack tree in the Debugger sidebar should mark the active call frame. Currently, there is no way to tell which call frame is active when another tree contains the selection.

Note:
Xcode shows an indicator (similar to the Inspector's instruction pointer marker) in the left side of the tree element. The indicator color depends on the parent tree element state:

Default = gray
Selected = dark gray
Selected|Focused = white

[Radar WebKit Bug Importer]

<rdar://problem/28293451>

[Matt Baker]

Created attachment 288764 [details]
[Image] Xcode UI

[Matt Baker]

Created attachment 288765 [details]
[Image] Xcode UI - active call frame unfocused

[Matt Baker]

Created attachment 288766 [details]
[Patch] Proposed Fix

[Matt Baker]

Created attachment 288768 [details]
[Video] with patch applied

[Joseph Pecoraro]

Comment on attachment 288766 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=288766&action=review

r=me, the video looks great!!

How does it look @1x? I assume as SVG it will look fine, but it would be worth checking out.
Should it have window inactive styles? My guess is no.

> Source/WebInspectorUI/UserInterface/Images/ActiveCallFrame.svg:1
> +<?xml version="1.0" encoding="utf-8"?>

We should file a bug on GTK to add an Images/gtk/ActiveCallFrame.svg image and ensure they don't utterly break if the image is missing.

> Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.js:97
> +        if (!this._statusImageElement)
> +            this._statusImageElement = useSVGSymbol("Images/ActiveCallFrame.svg", "status-image");

If the image is missing (GTK) will this throw a runtime error? If so, we will need to be graceful somehow.

[Matt Baker]

(In reply to comment #6)
> Comment on attachment 288766 [details]
> [Patch] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=288766&action=review
> 
> r=me, the video looks great!!
> 
> How does it look @1x? I assume as SVG it will look fine, but it would be
> worth checking out.

It looks acceptable.

> Should it have window inactive styles? My guess is no.
Correct!

> > Source/WebInspectorUI/UserInterface/Images/ActiveCallFrame.svg:1
> > +<?xml version="1.0" encoding="utf-8"?>
> 
> We should file a bug on GTK to add an Images/gtk/ActiveCallFrame.svg image
> and ensure they don't utterly break if the image is missing.

Will do.

> > Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.js:97
> > +        if (!this._statusImageElement)
> > +            this._statusImageElement = useSVGSymbol("Images/ActiveCallFrame.svg", "status-image");
> 
> If the image is missing (GTK) will this throw a runtime error? If so, we
> will need to be graceful somehow.

A "Failed to load resource" error is shown in the Inspector^2 console, but there are no other side effects.

[Matt Baker]

Comment on attachment 288766 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=288766&action=review

>>> Source/WebInspectorUI/UserInterface/Images/ActiveCallFrame.svg:1
>>> +<?xml version="1.0" encoding="utf-8"?>
>> 
>> We should file a bug on GTK to add an Images/gtk/ActiveCallFrame.svg image and ensure they don't utterly break if the image is missing.
> 
> Will do.

https://bugs.webkit.org/show_bug.cgi?id=161987

[WebKit Commit Bot]

Comment on attachment 288766 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 288766

Committed r205930: <http://trac.webkit.org/changeset/205930>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.