Bug 161934 - Treat some CSS properties as keyword properties
Summary: Treat some CSS properties as keyword properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-13 16:29 PDT by Daniel Bates
Modified: 2016-09-13 17:12 PDT (History)
4 users (show)

See Also:

Attachments
Patch (15.87 KB, patch)
2016-09-13 16:33 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-09-13 16:29:32 PDT 
Make the following CSS properties as keyword properties:

CSSPropertyColumnProgression
CSSPropertyFontStretch
CSSPropertyTextAlign
CSSPropertyUnicodeBidi
CSSPropertyWebkitColumnAxis
CSSPropertyWebkitCursorVisibility
CSSPropertyWebkitTextDecorationStyle
CSSPropertyWebkitTextOrientation
CSSPropertyWebkitTextZoom
CSSPropertyWebkitTouchCallout

These properties only accepts values that are keywords. Treating these properties as keyword properties is a step towards migrating from CSSParser::is{KeywordPropertyID, ValidKeywordPropertyAndValue}() to CSSParserFastPaths::is{KeywordPropertyID, ValidKeywordPropertyAndValue}(), respectively.
Comment 1 Daniel Bates 2016-09-13 16:33:07 PDT 
Created attachment 288744 [details]
Patch
Comment 2 Daniel Bates 2016-09-13 17:12:27 PDT 
Comment on attachment 288744 [details]
Patch

Clearing flags on attachment: 288744

Committed r205888: <http://trac.webkit.org/changeset/205888>
Comment 3 Daniel Bates 2016-09-13 17:12:32 PDT 
All reviewed patches have been landed.  Closing bug.