Bug 161929 – Promises aren't resolved properly when making a ObjC API callback

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

If a promise is resolved or rejected and the resolution handler is queue but hasn't been processed when an ObjC function callback is invoked, the promise resolution internal builtins may not compile properly.

[Michael Saboff]

rdar://problem/27992169

[Michael Saboff]

Created attachment 288735 [details]
Patch

[Geoffrey Garen]

Comment on attachment 288735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288735&action=review

r=me

It occurs to me that it is also a bug that we drain the micro task queue at all when calling out to ObjC. That should only happen when we exit the VM.

> Source/JavaScriptCore/ChangeLog:3
> +        Promises aren't resolved properly when making a ObcC API callback

ObjC

> Source/JavaScriptCore/ChangeLog:8
> +        When we go to call out to an Objective C functions registered via the API,

function

[Michael Saboff]

(In reply to comment #3)
> Comment on attachment 288735 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=288735&action=review
> 
> r=me
> 
> It occurs to me that it is also a bug that we drain the micro task queue at
> all when calling out to ObjC. That should only happen when we exit the VM.

I filed https://bugs.webkit.org/show_bug.cgi?id=161942 to track this.

> > Source/JavaScriptCore/ChangeLog:3
> > +        Promises aren't resolved properly when making a ObcC API callback
> 
> ObjC

Fixed.

> > Source/JavaScriptCore/ChangeLog:8
> > +        When we go to call out to an Objective C functions registered via the API,
> 
> function

Fixed.

[Michael Saboff]

Committed r205895: <http://trac.webkit.org/changeset/205895>