Bug 161928 - Atomics on ARM don't require full-system fencing, and other minutiae
Summary: Atomics on ARM don't require full-system fencing, and other minutiae
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-13 14:24 PDT by JF Bastien
Modified: 2016-09-14 11:53 PDT (History)
5 users (show)

See Also:

Attachments
patch (6.52 KB, patch)
2016-09-13 14:36 PDT, JF Bastien 		no flags Details | Formatted Diff | Diff
patch (6.52 KB, patch)
2016-09-13 15:08 PDT, JF Bastien 		ggaren: review+
Details | Formatted Diff | Diff
patch (6.54 KB, patch)
2016-09-14 10:29 PDT, JF Bastien 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch (6.54 KB, patch)
2016-09-14 11:15 PDT, JF Bastien 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch (6.54 KB, patch)
2016-09-14 11:20 PDT, JF Bastien 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2016-09-13 14:24:05 PDT 
.
Comment 1 JF Bastien 2016-09-13 14:36:26 PDT 
Created attachment 288732 [details]
patch

This should be a pretty simple first-step. Let's see how it affects performance, and I can follow-up on individual uses one-by-one afterwards.
Comment 2 JF Bastien 2016-09-13 15:08:53 PDT 
Created attachment 288733 [details]
patch

Fix think-o in debug build. Silly.
Comment 3 Geoffrey Garen 2016-09-13 15:12:00 PDT 
Comment on attachment 288733 [details]
patch

r=me
Comment 4 JF Bastien 2016-09-14 10:29:18 PDT 
Created attachment 288830 [details]
patch

Rebase on top of https://bugs.webkit.org/show_bug.cgi?id=155371 and add ALWAYS_INLINE on the new overloads.
Comment 5 WebKit Commit Bot 2016-09-14 10:47:08 PDT 
Comment on attachment 288830 [details]
patch

Rejecting attachment 288830 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 288830, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2073253
Comment 6 JF Bastien 2016-09-14 11:15:57 PDT 
Created attachment 288834 [details]
patch

s/OOPS/ggaren/
Comment 7 WebKit Commit Bot 2016-09-14 11:17:28 PDT 
Comment on attachment 288834 [details]
patch

Rejecting attachment 288834 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 288834, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Geoff Garren found in /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/2073404
Comment 8 JF Bastien 2016-09-14 11:20:53 PDT 
Created attachment 288835 [details]
patch

I fail at spelingz.
Comment 9 WebKit Commit Bot 2016-09-14 11:53:33 PDT 
Comment on attachment 288835 [details]
patch

Clearing flags on attachment: 288835

Committed r205921: <http://trac.webkit.org/changeset/205921>
Comment 10 WebKit Commit Bot 2016-09-14 11:53:39 PDT 
All reviewed patches have been landed.  Closing bug.