Bug 161922 - MapHash should speculate on the type of its child node
Summary: MapHash should speculate on the type of its child node
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-13 12:11 PDT by Saam Barati
Modified: 2016-10-04 02:22 PDT (History)
16 users (show)

See Also:

Attachments
WIP (13.56 KB, patch)
2016-09-13 19:52 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (17.25 KB, patch)
2016-09-30 17:39 PDT, Saam Barati 		fpizlo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-09-13 12:11:56 PDT 
...
Comment 1 Saam Barati 2016-09-13 19:52:20 PDT 
Created attachment 288763 [details]
WIP

I think this is the patch, I just need to write a changelog.
At some point, I want to make things fast for doubles too.
Comment 2 Saam Barati 2016-09-30 17:39:16 PDT 
Created attachment 290410 [details]
patch
Comment 3 Saam Barati 2016-10-03 13:52:24 PDT 
landed in:
https://trac.webkit.org/changeset/206746
Comment 5 Saam Barati 2016-10-04 01:34:06 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > landed in:
> > https://trac.webkit.org/changeset/206746
> 
> It made many tests assert on 32 bit Apple Mac JSC bots:
> -
> https://build.webkit.org/builders/Apple%20El%20Capitan%2032-
> bit%20JSC%20%28BuildAndTest%29/builds/3863
> -
> https://build.webkit.org/builders/Apple%20Yosemite%2032-
> bit%20JSC%20%28BuildAndTest%29/builds/10854

Will fix. Thanks.
Comment 6 Saam Barati 2016-10-04 02:12:55 PDT 
Fix coming soon, just testing.
Comment 7 Saam Barati 2016-10-04 02:22:32 PDT 
landed 32-bit fix in:
https://trac.webkit.org/changeset/206767