Bug 161918 - Remove CSS keyword properties from CSSParser::parseValue(CSSPropertyID, bool)
Summary: Remove CSS keyword properties from CSSParser::parseValue(CSSPropertyID, bool)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-13 11:35 PDT by Daniel Bates
Modified: 2016-09-13 12:03 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.52 KB, patch)
2016-09-13 11:57 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (6.54 KB, patch)
2016-09-13 11:59 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-09-13 11:35:22 PDT 
There is little to no value in calling ASSERT_NOT_REACHED() from CSSParser::parseValue(CSSPropertyID, bool) when processing a CSS keyword property (properties that only accept keyword values) given that the switch block in CSSParser::parseValue(CSSPropertyID, bool) defaults to parsing a unrecognized CSS properties as SVG CSS properties. We should remove all CSS keyword property case statements from CSSParser::parseValue(CSSPropertyID, bool).
Comment 1 Daniel Bates 2016-09-13 11:57:10 PDT 
Created attachment 288708 [details]
Patch
Comment 2 Daniel Bates 2016-09-13 11:59:32 PDT 
Created attachment 288709 [details]
Patch

Fix wording in ChangeLog.
Comment 3 Daniel Bates 2016-09-13 12:03:38 PDT 
Comment on attachment 288709 [details]
Patch

Clearing flags on attachment: 288709

Committed r205868: <http://trac.webkit.org/changeset/205868>
Comment 4 Daniel Bates 2016-09-13 12:03:42 PDT 
All reviewed patches have been landed.  Closing bug.