Bug 161916 - [CSS Parser] Add CSS Variable Parsing support
Summary: [CSS Parser] Add CSS Variable Parsing support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46591
  Show dependency tree / graph
 
Reported: 2016-09-13 11:04 PDT by Dave Hyatt
Modified: 2016-09-22 13:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (60.13 KB, patch)
2016-09-13 11:08 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (60.09 KB, patch)
2016-09-13 11:13 PDT, Dave Hyatt 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2016-09-13 11:04:58 PDT 
[CSS Parser] Add CSS Variable Parsing support
Comment 1 Dave Hyatt 2016-09-13 11:08:28 PDT 
Created attachment 288701 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-13 11:11:25 PDT 
Attachment 288701 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSVariableData.cpp:51:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/CSSVariableData.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2016-09-13 11:13:10 PDT 
Created attachment 288703 [details]
Patch
Comment 4 Dave Hyatt 2016-09-13 12:10:49 PDT 
Landed in r205869.