Bug 161915 – LayoutTest http/tests/cache/disk-cache/disk-cache-validation-attachment.html is a flaky failure

• Status: NEW
• Component: New Bugs

[Ryan Haddad]

LayoutTest http/tests/cache/disk-cache/disk-cache-validation-attachment.html is a flaky failure

https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/8143

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fcache%2Fdisk-cache%2Fdisk-cache-validation-attachment.html

--- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/http/tests/cache/disk-cache/disk-cache-validation-attachment-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/http/tests/cache/disk-cache/disk-cache-validation-attachment-actual.txt
@@ -26,38 +26,38 @@
 
 --------Testing loads through memory cache (XHR behavior)--------
 response headers: undefined
-response source: Network
+response source: Memory cache
 
 response headers: {"Cache-control":"max-age=0"}
-response source: Network
+response source: Memory cache
 
 response headers: {"Cache-control":"max-age=100"}
 response source: Memory cache
 
 response headers: {"Content-Disposition":"attachment; filename=\"f.txt\""}
-response source: Network
+response source: Memory cache
 
 response headers: {"Cache-control":"max-age=0","Content-Disposition":"attachment; filename=\"f.txt\""}
-response source: Network
+response source: Memory cache
 
 response headers: {"Cache-control":"max-age=100","Content-Disposition":"attachment; filename=\"f.txt\""}
 response source: Memory cache
 
 --------Testing loads through memory cache (subresource behavior)--------
 response headers: undefined
-response source: Network
+response source: Memory cache
 
 response headers: {"Cache-control":"max-age=0"}
-response source: Network
+response source: Memory cache
 
 response headers: {"Cache-control":"max-age=100"}
 response source: Memory cache
 
 response headers: {"Content-Disposition":"attachment; filename=\"f.txt\""}
-response source: Network
+response source: Memory cache
 
 response headers: {"Cache-control":"max-age=0","Content-Disposition":"attachment; filename=\"f.txt\""}
-response source: Network
+response source: Memory cache
 
 response headers: {"Cache-control":"max-age=100","Content-Disposition":"attachment; filename=\"f.txt\""}
 response source: Memory cache

[Ryan Haddad]

According to the flakiness dashboard, the first failure was around https://trac.webkit.org/log/?verbose=on&rev=205089&stop_rev=205087

[Alexey Proskuryakov]

Saw this test fail on Sierra WK2 Release locally too.

[Alexey Proskuryakov]

Interesting Apache logging in error_log. Antti, does this ring the bell?

[Tue Jan 31 17:27:25.694277 2017] [http:error] [pid 43016] [client 127.0.0.1:60056] AH02429: Response header name ' filename' contains invalid characters, aborting request, referer: http://127.0.0.1:8000/cache/disk-cache/disk-cache-validation-attachment.html
[Tue Jan 31 17:27:26.555042 2017] [http:error] [pid 43025] [client 127.0.0.1:60059] AH02429: Response header name ' filename' contains invalid characters, aborting request, referer: http://127.0.0.1:8000/cache/disk-cache/disk-cache-validation-attachment.html
[Tue Jan 31 17:27:26.587168 2017] [http:error] [pid 43025] [client 127.0.0.1:60061] AH02429: Response header name ' filename' contains invalid characters, aborting request, referer: http://127.0.0.1:8000/cache/disk-cache/disk-cache-validation-attachment.html
[Tue Jan 31 17:27:26.776377 2017] [http:error] [pid 43026] [client 127.0.0.1:60060] AH02429: Response header name ' filename' contains invalid characters, aborting request, referer: http://127.0.0.1:8000/cache/disk-cache/disk-cache-validation-attachment.html
[Tue Jan 31 17:27:26.777433 2017] [http:error] [pid 43025] [client 127.0.0.1:60062] AH02429: Response header name ' filename' contains invalid characters, aborting request, referer: http://127.0.0.1:8000/cache/disk-cache/disk-cache-validation-attachment.html
[Tue Jan 31 17:27:26.810219 2017] [http:error] [pid 43025] [client 127.0.0.1:60063] AH02429: Response header name ' filename' contains invalid characters, aborting request, referer: http://127.0.0.1:8000/cache/disk-cache/disk-cache-validation-attachment.html
[Tue Jan 31 17:27:26.898368 2017] [http:error] [pid 43026] [client 127.0.0.1:60064] AH02429: Response header name ' filename' contains invalid characters, aborting request, referer: http://127.0.0.1:8000/cache/disk-cache/disk-cache-validation-attachment.html
[Tue Jan 31 17:27:26.899149 2017] [http:error] [pid 43025] [client 127.0.0.1:60065] AH02429: Response header name ' filename' contains invalid characters, aborting request, referer: http://127.0.0.1:8000/cache/disk-cache/disk-cache-validation-attachment.html
[Tue Jan 31 17:27:26.977227 2017] [http:error] [pid 43026] [client 127.0.0.1:60066] AH02429: Response header name ' filename' contains invalid characters, aborting request, referer: http://127.0.0.1:8000/cache/disk-cache/disk-cache-validation-attachment.html
[Tue Jan 31 17:27:27.064534 2017] [http:error] [pid 43025] [client 127.0.0.1:60067] AH02429: Response header name ' filename' contains invalid characters, aborting request, referer: http://127.0.0.1:8000/cache/disk-cache/disk-cache-validation-attachment.html
[Tue Jan 31 17:27:27.064825 2017] [http:error] [pid 43026] [client 127.0.0.1:60068] AH02429: Response header name ' filename' contains invalid characters, aborting request, referer: http://127.0.0.1:8000/cache/disk-cache/disk-cache-validation-attachment.html
[Tue Jan 31 17:27:27.144283 2017] [http:error] [pid 43025] [client 127.0.0.1:60069] AH02429: Response header name ' filename' contains invalid characters, aborting request, referer: http://127.0.0.1:8000/cache/disk-cache/disk-cache-validation-attachment.html

[Alexey Proskuryakov]

That may be a different issue - this failure is not flaky for me, and a few other tests have a similar one.