Bug 161896 - Provide a mechanism to specify the maximum width of WKThumbnailView snapshots
Summary: Provide a mechanism to specify the maximum width of WKThumbnailView snapshots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-13 01:25 PDT by Tim Horton
Modified: 2016-09-13 14:11 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.60 KB, patch)
2016-09-13 01:26 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (8.61 KB, patch)
2016-09-13 13:56 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2016-09-13 01:25:57 PDT 
Provide a mechanism to specify the maximum width of WKThumbnailView snapshots
Comment 1 Tim Horton 2016-09-13 01:26:38 PDT 
Created attachment 288679 [details]
Patch
Comment 2 Tim Horton 2016-09-13 01:27:54 PDT 
<rdar://problem/28229827>
Comment 3 Simon Fraser (smfr) 2016-09-13 11:45:11 PDT 
Comment on attachment 288679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288679&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKThumbnailView.h:43
> +@property (nonatomic) CGFloat maximumSnapshotWidth;

What if someone wants to constrain by height?
Comment 4 Tim Horton 2016-09-13 13:56:09 PDT 
Created attachment 288726 [details]
Patch
Comment 5 Simon Fraser (smfr) 2016-09-13 14:09:31 PDT 
Comment on attachment 288726 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288726&action=review

> Source/WebKit2/ChangeLog:3
> +        Provide a mechanism to specify the maximum width of WKThumbnailView snapshots

Now maximum size

> Tools/ChangeLog:3
> +        Provide a mechanism to specify the maximum width of WKThumbnailView snapshots

size
Comment 6 Tim Horton 2016-09-13 14:11:57 PDT 
https://trac.webkit.org/changeset/205878