WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
161896
Provide a mechanism to specify the maximum width of WKThumbnailView snapshots
https://bugs.webkit.org/show_bug.cgi?id=161896
Summary
Provide a mechanism to specify the maximum width of WKThumbnailView snapshots
Tim Horton
Reported
2016-09-13 01:25:57 PDT
Provide a mechanism to specify the maximum width of WKThumbnailView snapshots
Attachments
Patch
(7.60 KB, patch)
2016-09-13 01:26 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Patch
(8.61 KB, patch)
2016-09-13 13:56 PDT
,
Tim Horton
simon.fraser
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2016-09-13 01:26:38 PDT
Created
attachment 288679
[details]
Patch
Tim Horton
Comment 2
2016-09-13 01:27:54 PDT
<
rdar://problem/28229827
>
Simon Fraser (smfr)
Comment 3
2016-09-13 11:45:11 PDT
Comment on
attachment 288679
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=288679&action=review
> Source/WebKit2/UIProcess/API/Cocoa/_WKThumbnailView.h:43 > +@property (nonatomic) CGFloat maximumSnapshotWidth;
What if someone wants to constrain by height?
Tim Horton
Comment 4
2016-09-13 13:56:09 PDT
Created
attachment 288726
[details]
Patch
Simon Fraser (smfr)
Comment 5
2016-09-13 14:09:31 PDT
Comment on
attachment 288726
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=288726&action=review
> Source/WebKit2/ChangeLog:3 > + Provide a mechanism to specify the maximum width of WKThumbnailView snapshots
Now maximum size
> Tools/ChangeLog:3 > + Provide a mechanism to specify the maximum width of WKThumbnailView snapshots
size
Tim Horton
Comment 6
2016-09-13 14:11:57 PDT
https://trac.webkit.org/changeset/205878
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug