Fix post-landing review comments after r205787.
https://bugs.webkit.org/show_bug.cgi?id=161669#c18
Created attachment 288639 [details] Patch
Comment on attachment 288639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288639&action=review Looks good. > Source/WTF/wtf/text/StringBuilder.cpp:309 > +#if USE(CF) Other classes use a separate source file for the CF stuff. But I suppose it’s too much to ask to add a StringBuilderCF.cpp just for this. > Source/WTF/wtf/text/StringBuilder.cpp:314 > + if (auto* characters = CFStringGetCStringPtr(string, kCFStringEncodingASCII)) { Why not kCFStringEncodingISOLatin1? It seems a little strange that this code is so different from the code in StringCF.cpp. > Source/WTF/wtf/text/StringBuilder.h:110 > +#if USE(CF) > + WTF_EXPORT_PRIVATE void append(CFStringRef); > +#ifdef __OBJC__ > + void append(NSString *string) { append((__bridge CFStringRef)string); } > +#endif > +#endif In the past I have often written these as separate if statements just to avoid hard-to-read nesting. #if USE(CF) WTF_EXPORT_PRIVATE void append(CFStringRef); #endif #if USE(CF) && defined(__OBJC__) void append(NSString *string) { append((__bridge CFStringRef)string); } #endif I think that’s slightly better. > Source/WebCore/html/parser/HTMLParserIdioms.cpp:366 > - Optional<unsigned> number = parseHTMLNonNegativeInteger(StringView(numberStart, position - numberStart)); > + Optional<unsigned> number = parseHTMLNonNegativeInteger({ numberStart, static_cast<unsigned>(position - numberStart) }); Darn, that cast to unsigned we need here makes it not quite as great as I had hoped.
Created attachment 288654 [details] Patch
Comment on attachment 288654 [details] Patch Clearing flags on attachment: 288654 Committed r205847: <http://trac.webkit.org/changeset/205847>
All reviewed patches have been landed. Closing bug.