WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
16186
Reduce number of c-stack-based MatchFrames
https://bugs.webkit.org/show_bug.cgi?id=16186
Summary
Reduce number of c-stack-based MatchFrames
Eric Seidel (no email)
Reported
2007-11-29 04:12:23 PST
Reduce number of c-stack-based MatchFrames I believe the credit for this idea goes to Darin, I heard about it through Maciej. Currently we allocate space for 16 match frames every time we call into match(). That's excessive, since very very very few regexps ever go beyond a few frames. Supposedly darin tried this and found that reducing to 4 frames was a big speedup. I expect we could probably reduce to 8 frames w/o worrying too much about affecting real-world performance. Until
bug 16185
is fixed, we always use 2 frames for every regexp. :(
Attachments
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2007-11-29 05:06:11 PST
I just tested reducing FRAMES_ON_STACK to 8 and 4, and saw no change in SunSpider. Unless I missed something, we might just want to close this bug.
Gavin Barraclough
Comment 2
2011-09-06 22:31:16 PDT
This is a proposed optimization for PCRE; we no longer use PCRE.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug