Bug 161857 - [DFG][FTL] Add ArithTan
Summary: [DFG][FTL] Add ArithTan
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-11 23:49 PDT by Yusuke Suzuki
Modified: 2016-09-12 16:14 PDT (History)
6 users (show)

See Also:

Attachments
Patch (29.96 KB, patch)
2016-09-11 23:55 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-09-11 23:49:03 PDT 
[DFG][FTL] Add ArithTan
Comment 1 Yusuke Suzuki 2016-09-11 23:55:40 PDT 
Created attachment 288556 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-12 15:03:18 PDT 
Comment on attachment 288556 [details]
Patch

Clearing flags on attachment: 288556

Committed r205828: <http://trac.webkit.org/changeset/205828>
Comment 3 WebKit Commit Bot 2016-09-12 15:03:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ryan Haddad 2016-09-12 15:56:32 PDT 
stress/ftl-arithtan.js appears to be failing on Yosemite Release JSC tests (other bots are behind, so this may eventually fail on other configurations too)

https://build.webkit.org/builders/Apple%20Yosemite%20Release%20JSC%20(Tests)/builds/14218/steps/jscore-test/logs/stdio
Comment 5 Yusuke Suzuki 2016-09-12 16:08:13 PDT 
(In reply to comment #4)
> stress/ftl-arithtan.js appears to be failing on Yosemite Release JSC tests
> (other bots are behind, so this may eventually fail on other configurations
> too)
> 
> https://build.webkit.org/builders/Apple%20Yosemite%20Release%20JSC%20(Tests)/
> builds/14218/steps/jscore-test/logs/stdio

Ah, ok. This is due to different results produced from different libms.
I created this test case on Linux box, and the result seems slightly different from libm on OS X. (-1.687173625802563 v.s. -1.6871736258025631).
I'll fix this test soon.
Comment 6 Yusuke Suzuki 2016-09-12 16:14:05 PDT 
Committed r205837: <http://trac.webkit.org/changeset/205837>