Bug 161848 - REGRESSION (r205223): Web Inspector: Debugger popover title and code aren't horizontally aligned
Summary: REGRESSION (r205223): Web Inspector: Debugger popover title and code aren't h...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-11 12:17 PDT by Nikita Vasilyev
Modified: 2016-09-12 15:37 PDT (History)
8 users (show)

See Also:


Attachments
[Image] Bug (47.29 KB, image/png)
2016-09-11 12:17 PDT, Nikita Vasilyev
no flags Details
Patch (1.41 KB, patch)
2016-09-11 12:26 PDT, Nikita Vasilyev
mattbaker: review+
mattbaker: commit-queue-
Details | Formatted Diff | Diff
[Image] With patch applied (52.93 KB, image/png)
2016-09-11 12:31 PDT, Nikita Vasilyev
no flags Details
Patch (2.11 KB, patch)
2016-09-12 15:08 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Image] With patch applied (52.44 KB, image/png)
2016-09-12 15:09 PDT, Nikita Vasilyev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-09-11 12:17:22 PDT
Created attachment 288530 [details]
[Image] Bug

The code is shifted a few pixels on the right. Must be a recent regression.
Comment 1 Radar WebKit Bug Importer 2016-09-11 12:17:58 PDT
<rdar://problem/28250703>
Comment 2 Nikita Vasilyev 2016-09-11 12:18:53 PDT
Regressed in bug 161417: Web Inspector: Remove largest common indentation spacing in debugger popover
Comment 3 Nikita Vasilyev 2016-09-11 12:26:59 PDT
Created attachment 288531 [details]
Patch
Comment 4 Nikita Vasilyev 2016-09-11 12:31:27 PDT
Created attachment 288532 [details]
[Image] With patch applied
Comment 5 Matt Baker 2016-09-11 16:14:38 PDT
Comment on attachment 288531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288531&action=review

> Source/WebInspectorUI/ChangeLog:11
> +        Overwrite left padding defined in CodeMirrorOverrides.css by `.CodeMirror pre` rule.

Should be "Override".
Comment 6 Devin Rousso 2016-09-11 16:47:51 PDT
(In reply to comment #4)
> Created attachment 288532 [details]
> [Image] With patch applied

Personally, I find it odd that the function name has a left padding while the source link doesn't have any right padding.  Should we consider removing the padding for the function name altogether?
Comment 7 Matt Baker 2016-09-11 17:14:19 PDT
(In reply to comment #6)
> (In reply to comment #4)
> > Created attachment 288532 [details]
> > [Image] With patch applied
> 
> Personally, I find it odd that the function name has a left padding while
> the source link doesn't have any right padding.  Should we consider removing
> the padding for the function name altogether?

I didn't notice that! They should be the same.
Comment 8 Nikita Vasilyev 2016-09-12 15:08:45 PDT
Created attachment 288618 [details]
Patch
Comment 9 Nikita Vasilyev 2016-09-12 15:09:27 PDT
Created attachment 288619 [details]
[Image] With patch applied
Comment 10 WebKit Commit Bot 2016-09-12 15:37:25 PDT
Comment on attachment 288618 [details]
Patch

Clearing flags on attachment: 288618

Committed r205832: <http://trac.webkit.org/changeset/205832>
Comment 11 WebKit Commit Bot 2016-09-12 15:37:29 PDT
All reviewed patches have been landed.  Closing bug.