Bug 161846 - Candidates that don't end in spaces shouldn't have spaces arbitrarily appended to them
Summary: Candidates that don't end in spaces shouldn't have spaces arbitrarily appende...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-10 18:33 PDT by Tim Horton
Modified: 2016-09-11 00:26 PDT (History)
6 users (show)

See Also:


Attachments
Patch (14.76 KB, patch)
2016-09-10 18:34 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (1.04 MB, application/zip)
2016-09-10 19:28 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (921.76 KB, application/zip)
2016-09-10 19:31 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.52 MB, application/zip)
2016-09-10 19:37 PDT, Build Bot
no flags Details
Patch (35.94 KB, patch)
2016-09-10 20:28 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.03 MB, application/zip)
2016-09-10 21:26 PDT, Build Bot
no flags Details
Patch (36.02 KB, patch)
2016-09-10 21:38 PDT, Tim Horton
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2016-09-10 18:33:50 PDT
Candidates that don't end in spaces shouldn't have spaces arbitrarily appended to them
Comment 1 Tim Horton 2016-09-10 18:34:20 PDT
Created attachment 288513 [details]
Patch
Comment 2 Build Bot 2016-09-10 19:27:57 PDT
Comment on attachment 288513 [details]
Patch

Attachment 288513 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2050502

New failing tests:
editing/mac/spelling/accept-misspelled-candidate.html
Comment 3 Build Bot 2016-09-10 19:28:01 PDT
Created attachment 288515 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-09-10 19:31:36 PDT
Comment on attachment 288513 [details]
Patch

Attachment 288513 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2050505

New failing tests:
editing/mac/spelling/accept-misspelled-candidate.html
Comment 5 Build Bot 2016-09-10 19:31:40 PDT
Created attachment 288516 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Tim Horton 2016-09-10 19:32:47 PDT
(In reply to comment #2)
> Comment on attachment 288513 [details]
> Patch
> 
> Attachment 288513 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.webkit.org/results/2050502
> 
> New failing tests:
> editing/mac/spelling/accept-misspelled-candidate.html

Ooh, this seems like an actual bug, and indicates that the code that I thought looked wrong (the document marker) actually is! I'll fix it and post a new patch in a moment.
Comment 7 Build Bot 2016-09-10 19:37:47 PDT
Comment on attachment 288513 [details]
Patch

Attachment 288513 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2050514

New failing tests:
editing/mac/spelling/accept-misspelled-candidate.html
Comment 8 Build Bot 2016-09-10 19:37:51 PDT
Created attachment 288517 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Tim Horton 2016-09-10 20:28:10 PDT
Created attachment 288518 [details]
Patch
Comment 10 Build Bot 2016-09-10 21:26:13 PDT
Comment on attachment 288518 [details]
Patch

Attachment 288518 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2050962

New failing tests:
editing/mac/spelling/accept-candidate-allows-autocorrect-on-next-word.html
Comment 11 Build Bot 2016-09-10 21:26:17 PDT
Created attachment 288520 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 12 Tim Horton 2016-09-10 21:35:10 PDT
It is... expected that that test doesn't work in WebKit2. I thought I said that in TestExpectations.
Comment 13 Tim Horton 2016-09-10 21:38:26 PDT
Created attachment 288521 [details]
Patch
Comment 14 Tim Horton 2016-09-11 00:26:47 PDT
https://trac.webkit.org/changeset/205788