Bug 161837 - Optimize URLParser performance
Summary: Optimize URLParser performance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-09 23:06 PDT by Alex Christensen
Modified: 2016-09-12 11:09 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.99 KB, patch)
2016-09-09 23:09 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (6.73 KB, patch)
2016-09-10 16:42 PDT, Alex Christensen 		beidson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-09-09 23:06:12 PDT 
Optimize URLParser performance
Comment 1 Alex Christensen 2016-09-09 23:09:42 PDT 
Created attachment 288482 [details]
Patch
Comment 2 Alex Christensen 2016-09-10 16:42:25 PDT 
Created attachment 288509 [details]
Patch
Comment 3 Brady Eidson 2016-09-12 10:37:40 PDT 
Comment on attachment 288509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288509&action=review

> Source/WebCore/platform/URLParser.cpp:137
> +    const uint16_t ftpPort = 21;
> +    const uint16_t gopherPort = 70;
> +    const uint16_t httpPort = 80;
> +    const uint16_t httpsPort = 433;
> +    const uint16_t wsPort = 80;
> +    const uint16_t wssPort = 433;

static const

> Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:489
> +    checkURL("hTtP://host:80", {"http", "", "", "host", 0, "/", "", "", "http://host/"});

If this test is worth adding, then similar mixed case tests are worth adding for *all* known schemes.
Comment 4 Alex Christensen 2016-09-12 11:09:17 PDT 
http://trac.webkit.org/changeset/205812