Bug 161835 – Web Inspector: Call frame is sometimes not selected in Debugger sidebar on initial pause

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
Call frame is sometimes not selected in Debugger sidebar on initial pause.

It should always be selected when we pause. It is on stepping, but sometimes not on the initial pause.

Steps to Reproduce:
1. Inspect <http://bogojoker.com/shell/>
2. Set a breakpoint on easySlider.min.js Line 5:35
3. Show the Debugger tab in Inspector
4. Select the easySlider.min.js resource in the sidebar
5. On the page click the down arrow under the screenshots to tigger breakpoint
  => Breakpoint triggered, Call frame not selected but it should be

Notes:
- Seems to have to do with the Script already being selected in the Debugger Sidebar. I couldn't reproduce without that step.

[Radar WebKit Bug Importer]

<rdar://problem/28236680>

[Matt Baker]

Created attachment 288885 [details]
[Patch] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 288885 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=288885&action=review

r=me! Good approach

> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:-672
> -        else {
> -            debugger;
> -        }

Err. This else debugger is not checked in. So that may be why this patch is not applying. Probably a diff from a local change.

[Matt Baker]

(In reply to comment #3)
> Comment on attachment 288885 [details]
> [Patch] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=288885&action=review
> 
> r=me! Good approach
> 
> > Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:-672
> > -        else {
> > -            debugger;
> > -        }
> 
> Err. This else debugger is not checked in. So that may be why this patch is
> not applying. Probably a diff from a local change.

Doh!

[Matt Baker]

Created attachment 288905 [details]
[Patch] For Landing

[WebKit Commit Bot]

Comment on attachment 288905 [details]
[Patch] For Landing

Clearing flags on attachment: 288905

Committed r205946: <http://trac.webkit.org/changeset/205946>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.