Bug 161835 - Web Inspector: Call frame is sometimes not selected in Debugger sidebar on initial pause
Summary: Web Inspector: Call frame is sometimes not selected in Debugger sidebar on in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-09 20:31 PDT by Joseph Pecoraro
Modified: 2016-09-14 21:56 PDT (History)
7 users (show)

See Also:


Attachments
[Patch] Proposed Fix (3.99 KB, patch)
2016-09-14 16:25 PDT, Matt Baker
no flags Details | Formatted Diff | Diff
[Patch] For Landing (4.04 KB, patch)
2016-09-14 17:44 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-09-09 20:31:45 PDT
Summary:
Call frame is sometimes not selected in Debugger sidebar on initial pause.

It should always be selected when we pause. It is on stepping, but sometimes not on the initial pause.

Steps to Reproduce:
1. Inspect <http://bogojoker.com/shell/>
2. Set a breakpoint on easySlider.min.js Line 5:35
3. Show the Debugger tab in Inspector
4. Select the easySlider.min.js resource in the sidebar
5. On the page click the down arrow under the screenshots to tigger breakpoint
  => Breakpoint triggered, Call frame not selected but it should be

Notes:
- Seems to have to do with the Script already being selected in the Debugger Sidebar. I couldn't reproduce without that step.
Comment 1 Radar WebKit Bug Importer 2016-09-09 20:32:04 PDT
<rdar://problem/28236680>
Comment 2 Matt Baker 2016-09-14 16:25:58 PDT
Created attachment 288885 [details]
[Patch] Proposed Fix
Comment 3 Joseph Pecoraro 2016-09-14 17:36:35 PDT
Comment on attachment 288885 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=288885&action=review

r=me! Good approach

> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:-672
> -        else {
> -            debugger;
> -        }

Err. This else debugger is not checked in. So that may be why this patch is not applying. Probably a diff from a local change.
Comment 4 Matt Baker 2016-09-14 17:38:08 PDT
(In reply to comment #3)
> Comment on attachment 288885 [details]
> [Patch] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=288885&action=review
> 
> r=me! Good approach
> 
> > Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:-672
> > -        else {
> > -            debugger;
> > -        }
> 
> Err. This else debugger is not checked in. So that may be why this patch is
> not applying. Probably a diff from a local change.

Doh!
Comment 5 Matt Baker 2016-09-14 17:44:06 PDT
Created attachment 288905 [details]
[Patch] For Landing
Comment 6 WebKit Commit Bot 2016-09-14 21:56:44 PDT
Comment on attachment 288905 [details]
[Patch] For Landing

Clearing flags on attachment: 288905

Committed r205946: <http://trac.webkit.org/changeset/205946>
Comment 7 WebKit Commit Bot 2016-09-14 21:56:48 PDT
All reviewed patches have been landed.  Closing bug.