Bug 161808 - Add ChakraCore tests to run-javascriptcore-tests
Summary: Add ChakraCore tests to run-javascriptcore-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-09 11:19 PDT by Michael Saboff
Modified: 2017-03-30 14:34 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.17 KB, patch)
2016-09-09 11:23 PDT, Michael Saboff 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2016-09-09 11:19:07 PDT 
The newly imported ChakraCore tests should be run by default with run-javascriptcore-tests
Comment 1 Michael Saboff 2016-09-09 11:23:10 PDT 
Created attachment 288417 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-09 12:17:47 PDT 
Comment on attachment 288417 [details]
Patch

Clearing flags on attachment: 288417

Committed r205759: <http://trac.webkit.org/changeset/205759>
Comment 3 WebKit Commit Bot 2016-09-09 12:17:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ryan Haddad 2016-09-09 15:46:17 PDT 
Reverted r205759 for reason:

This change broke all JSC tests

Committed r205773: <http://trac.webkit.org/changeset/205773>
Comment 6 Alexey Proskuryakov 2016-09-11 17:56:39 PDT 
How much time does this add?
Comment 7 Michael Saboff 2016-09-12 11:13:46 PDT 
(In reply to comment #6)
> How much time does this add?

On my MacPro system, less than a minute (~40 seconds).
Comment 8 Michael Saboff 2017-03-30 14:34:58 PDT 
This has long been fixed.