WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
161808
Add ChakraCore tests to run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=161808
Summary
Add ChakraCore tests to run-javascriptcore-tests
Michael Saboff
Reported
2016-09-09 11:19:07 PDT
The newly imported ChakraCore tests should be run by default with run-javascriptcore-tests
Attachments
Patch
(1.17 KB, patch)
2016-09-09 11:23 PDT
,
Michael Saboff
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Saboff
Comment 1
2016-09-09 11:23:10 PDT
Created
attachment 288417
[details]
Patch
WebKit Commit Bot
Comment 2
2016-09-09 12:17:47 PDT
Comment on
attachment 288417
[details]
Patch Clearing flags on attachment: 288417 Committed
r205759
: <
http://trac.webkit.org/changeset/205759
>
WebKit Commit Bot
Comment 3
2016-09-09 12:17:50 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 4
2016-09-09 15:46:17 PDT
Reverted
r205759
for reason: This change broke all JSC tests Committed
r205773
: <
http://trac.webkit.org/changeset/205773
>
Ryan Haddad
Comment 5
2016-09-09 15:46:55 PDT
(In reply to
comment #4
)
> Reverted
r205759
for reason: > > This change broke all JSC tests > > Committed
r205773
: <
http://trac.webkit.org/changeset/205773
>
https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/3651
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/4038
Alexey Proskuryakov
Comment 6
2016-09-11 17:56:39 PDT
How much time does this add?
Michael Saboff
Comment 7
2016-09-12 11:13:46 PDT
(In reply to
comment #6
)
> How much time does this add?
On my MacPro system, less than a minute (~40 seconds).
Michael Saboff
Comment 8
2017-03-30 14:34:58 PDT
This has long been fixed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug