Bug 161805 – URLParser: Handle \ in path according to spec

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

URLParser: Handle \ in path according to spec

[Alex Christensen]

Created attachment 288414 [details]
Patch

[WebKit Commit Bot]

Attachment 288414 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:266:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:266:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:417:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:417:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 4 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andy Estes]

Comment on attachment 288414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288414&action=review

> Source/WebCore/platform/URLParser.cpp:618
> +            {

Can we just put the entire case statement in a block?

> Source/WebCore/platform/URLParser.cpp:620
> +                bool isSlash = *c == '/' || (m_urlIsSpecial && *c == '\\');
> +                if (isSlash || *c == '?' || *c == '#') {

Can you dereference c once and store it in a char?

[Alex Christensen]

http://trac.webkit.org/changeset/205752

[Alex Christensen]

(In reply to comment #3)
> > Source/WebCore/platform/URLParser.cpp:620
> > +                bool isSlash = *c == '/' || (m_urlIsSpecial && *c == '\\');
> > +                if (isSlash || *c == '?' || *c == '#') {
> 
> Can you dereference c once and store it in a char?
I could, but I'm planning on optimizing all these if (*c==this || *c == that || ...) into tables once everything works anyways, so I'll get to it.  Until then, this reads better than having another variable with a strange name.