WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
161803
Web Inspector: combine-resources.pl should support multiple transformations in one invocation
https://bugs.webkit.org/show_bug.cgi?id=161803
Summary
Web Inspector: combine-resources.pl should support multiple transformations i...
Blaze Burg
Reported
2016-09-09 10:26:11 PDT
In the interest of moving more of the WebInspectorUI build into Derived Sources-style phases, we need to have a clearer relationship between inputs and outputs. Currently, combine-resources.pl is called multiple times, using the same files (Main.html, etc) as both inputs and outputs. This is fundamentally incompatible with dependency-based build systems, and makes it difficult to debug problems along the way. I think it would be better to make combine-resources.pl a bit less flexible and instead codify the conventions we have been using. In particular, * hard-code a list of targets to be concatenated or stripped, loosely based on folders. This would be the set {Inspector, Debug, Workers, CodeMirror, Esprima, ESLint} * each target has a hardcoded file pattern (such as 'External/Esprima') * output filenames are determined based on the target name plus a suffix * take arguments such as --combine=Inspector --combine=CodeMirror --strip=Debug --suffix=Combined This will reduce the number of invocations to one per main resource in copy-user-interface-resources.pl and make it possible to move this step into Derived Sources easily. There are still plenty of post-processing steps such as running minifiers and remove-console-asserts.pl. We can combine/streamline that stuff in a separate bug.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2016-09-09 10:26:33 PDT
<
rdar://problem/28227583
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug