Bug 161786 - URLParser should parse URLs with non-special schemes
Summary: URLParser should parse URLs with non-special schemes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-08 22:06 PDT by Alex Christensen
Modified: 2016-09-09 10:08 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.11 KB, patch)
2016-09-08 22:09 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (10.43 KB, patch)
2016-09-08 22:47 PDT, Alex Christensen
aestes: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-09-08 22:06:34 PDT
URLParser should parse URLs with non-special schemes
Comment 1 Alex Christensen 2016-09-08 22:09:57 PDT
Created attachment 288388 [details]
Patch
Comment 2 Alex Christensen 2016-09-08 22:47:53 PDT
Created attachment 288390 [details]
Patch
Comment 3 Andy Estes 2016-09-09 10:05:34 PDT
Comment on attachment 288390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288390&action=review

> Source/WebCore/platform/URLParser.cpp:465
> +                    auto checkForSlash = c;

Can we call this something like "maybeSlash" instead?
Comment 4 Alex Christensen 2016-09-09 10:08:37 PDT
http://trac.webkit.org/changeset/205749