RESOLVED FIXED 161783
Expose Apple Pencil data to Touch events 
https://bugs.webkit.org/show_bug.cgi?id=161783
Summary Expose Apple Pencil data to Touch events
Dean Jackson
Reported 2016-09-08 19:29:04 PDT
Now that UIKit and our internal touch code can detect Apple Pencil, provide the data from the device to the Touch event.
Attachments
Patch (26.10 KB, patch)
2016-09-08 19:40 PDT, Dean Jackson 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-09-08 19:29:31 PDT
<rdar://problem/28218898>
Dean Jackson
Comment 2 2016-09-08 19:40:16 PDT
Created attachment 288379 [details] Patch
WebKit Commit Bot
Comment 3 2016-09-08 19:42:10 PDT
Attachment 288379 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/WebEventConversion.cpp:261: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 4 2016-09-08 21:48:04 PDT
Comment on attachment 288379 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288379&action=review > Source/WebKit2/Shared/WebEventConversion.cpp:261 > + , webTouchPoint.force(), webTouchPoint.altitudeAngle(), webTouchPoint.azimuthAngle(), webPlatformTouchTypeToPlatform(webTouchPoint.touchType()) Is this whitespace necessary? > Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:438 > + _activePoints[0].pathPressure = pressure * 500; // The IOHID documentation says this should be [0,1], but in practice it is [0,500] :( FIXME?! Same goes for the below I suppose.
Dean Jackson
Comment 5 2016-09-09 14:00:25 PDT
Committed r205766: <http://trac.webkit.org/changeset/205766>
Note You need to log in before you can comment on or make changes to this bug.