Bug 161779 - Text replacement candidates don't always overwrite the entire original string
Summary: Text replacement candidates don't always overwrite the entire original string
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-08 17:38 PDT by Tim Horton
Modified: 2016-09-09 13:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (21.87 KB, patch)
2016-09-08 17:39 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (22.02 KB, patch)
2016-09-09 13:14 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2016-09-08 17:38:18 PDT
WebKit not always respecting range of candidates
Comment 1 Tim Horton 2016-09-08 17:39:22 PDT
Created attachment 288369 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-09-08 17:51:44 PDT
Comment on attachment 288369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288369&action=review

> Source/WebCore/ChangeLog:3
> +        WebKit not always respecting range of candidates

This title is not very helpful. Which candidates? "the range"?

> Source/WebCore/editing/Editor.cpp:3620
> +void Editor::selectTextCheckingResult(TextCheckingResult result)

Pass by reference? It's not tiny.
Comment 3 Tim Horton 2016-09-08 18:04:30 PDT
(In reply to comment #2)
> Comment on attachment 288369 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=288369&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        WebKit not always respecting range of candidates
> 
> This title is not very helpful. Which candidates? "the range"?

Heh, sure, will fix.

> > Source/WebCore/editing/Editor.cpp:3620
> > +void Editor::selectTextCheckingResult(TextCheckingResult result)
> 
> Pass by reference? It's not tiny.

Sure!
Comment 4 Tim Horton 2016-09-09 13:14:37 PDT
Created attachment 288432 [details]
Patch
Comment 5 Tim Horton 2016-09-09 13:37:30 PDT
<rdar://problem/28033492>
Comment 6 WebKit Commit Bot 2016-09-09 13:48:26 PDT
Comment on attachment 288432 [details]
Patch

Clearing flags on attachment: 288432

Committed r205765: <http://trac.webkit.org/changeset/205765>
Comment 7 WebKit Commit Bot 2016-09-09 13:48:30 PDT
All reviewed patches have been landed.  Closing bug.