WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
161771
Enhance Network logging
https://bugs.webkit.org/show_bug.cgi?id=161771
Summary
Enhance Network logging
Keith Rollin
Reported
2016-09-08 16:56:13 PDT
The initial logging used to track progress through the resource-downloading operation is a bit scattered. It would be better for it to conform to some sort of standard. By doing this, the logging can be more easily tracked and parsed (possibly by tools that try to extract important information from the logging. Change the logging to generally follow the format: <this> - <class>::<method>: <message> (<data>) <this>: Helps track activity for one particular instances, such as the downloading of one particular resource. <class>::<method>: Helps identify what stage of the operation we are in. <message>: Some arbitrary message, useful if a single method logs multiple times. Optional. <data>: Handy data to help us understand what's going on. Optional. For example: 0x110bf5000 - WebLoaderStrategy::scheduleLoad: Resource will be scheduled with the NetworkProcess (priority = 2, pageID = 6, frameID = 1, WebResourceLoader = 0x113858288) 0x113858288 - WebResourceLoader::didReceiveData: (size = 16384) 0x113858288 - WebResourceLoader::didFinishResourceLoad
Attachments
Patch
(22.55 KB, patch)
2016-09-09 11:00 PDT
,
Keith Rollin
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Keith Rollin
Comment 1
2016-09-09 11:00:33 PDT
Created
attachment 288415
[details]
Patch
WebKit Commit Bot
Comment 2
2016-09-12 12:01:37 PDT
Comment on
attachment 288415
[details]
Patch Clearing flags on attachment: 288415 Committed
r205817
: <
http://trac.webkit.org/changeset/205817
>
WebKit Commit Bot
Comment 3
2016-09-12 12:01:41 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug