Bug 161761 - Long tap menu on an image link no longer includes "Save Image" button
Summary: Long tap menu on an image link no longer includes "Save Image" button
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-08 14:08 PDT by Megan Gardner
Modified: 2016-10-12 04:45 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.66 KB, patch)
2016-09-08 14:21 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2016-09-08 14:08:49 PDT 
Long tap menu on an image link no longer includes "Save Image" button
Comment 1 Megan Gardner 2016-09-08 14:21:15 PDT 
Created attachment 288320 [details]
Patch
Comment 2 Tim Horton 2016-09-09 12:36:34 PDT 
Comment on attachment 288320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288320&action=review

> Source/WebKit2/ChangeLog:3
> +        Long tap menu on an image link no longer includes "Save Image" button

Is it possible to write a test for this?

> Source/WebKit2/ChangeLog:14
> +        Gather information for images as well as links, and they can be both

"and they can be both"?
Comment 3 Simon Fraser (smfr) 2016-09-09 13:04:07 PDT 
Comment on attachment 288320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288320&action=review

>> Source/WebKit2/ChangeLog:3
>> +        Long tap menu on an image link no longer includes "Save Image" button
> 
> Is it possible to write a test for this?

Probably not but we should make a way to do so.
Comment 4 Beth Dakin 2016-09-14 10:27:11 PDT 
Comment on attachment 288320 [details]
Patch

Megan is working on a follow-up patch to add test infrastructure and tests.
Comment 5 WebKit Commit Bot 2016-09-14 10:46:38 PDT 
Comment on attachment 288320 [details]
Patch

Clearing flags on attachment: 288320

Committed r205915: <http://trac.webkit.org/changeset/205915>
Comment 6 WebKit Commit Bot 2016-09-14 10:46:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 jessRD 2016-10-12 04:45:23 PDT 
Megan did awesome job here with the patch. As a follow-up at http://pimion.com I've saved a backup copy.