Bug 161754 - HTMLImageElement.hspace / vspace attributes should be unsigned
Summary: HTMLImageElement.hspace / vspace attributes should be unsigned
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/#HTMLIma...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-09-08 13:23 PDT by Chris Dumez
Modified: 2016-09-08 15:04 PDT (History)
9 users (show)

See Also:


Attachments
Patch (8.59 KB, patch)
2016-09-08 13:25 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (8.64 KB, patch)
2016-09-08 13:28 PDT, Chris Dumez
achristensen: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2 (7.22 MB, application/zip)
2016-09-08 15:02 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-09-08 13:23:50 PDT
HTMLImageElement.hspace / vspace attributes should be unsigned:
- https://html.spec.whatwg.org/#HTMLImageElement-partial

Firefox agrees with the specification, however, those are signed in webKit.
Comment 1 Chris Dumez 2016-09-08 13:25:10 PDT
Created attachment 288313 [details]
Patch
Comment 2 Chris Dumez 2016-09-08 13:28:04 PDT
Created attachment 288314 [details]
Patch
Comment 3 Build Bot 2016-09-08 15:02:17 PDT
Comment on attachment 288314 [details]
Patch

Attachment 288314 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2036469

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
Comment 4 Build Bot 2016-09-08 15:02:21 PDT
Created attachment 288335 [details]
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5
Comment 5 Chris Dumez 2016-09-08 15:04:41 PDT
Committed r205665: <http://trac.webkit.org/changeset/205665>